[INSTRM-2336] Cobra commanded step seemed larger than the maximum step Created: 15/Aug/24 Updated: 20/Sep/24 Resolved: 13/Sep/24 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_cobraCharmer |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | yuki.moritani | Assignee: | chyan |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Sprint: | PostRun18 | ||||||||
| Description |
|
As reported on |
| Comments |
| Comment by yuki.moritani [ 01/Sep/24 ] |
|
cf) visit=113619 took ~250sec and maximum step is as follows. Ite | ang_theta | ang_phi | step_theta | step_phi 0 | 418.95 | 126.36 | 4722 | 1030 1 | 414.80 | 77.84 | 5813 | 1747 2 | 421.98 | 180.00 | 6373 | 1257 3 | 426.32 | 180.00 | 7423 | 1197 4 | 385.61 | 180.00 | 5863 | 1831 5 | 366.06 | 180.82 | 5897 | 987 6 | 422.81 | 180.00 | 8312 | 686 7 | 395.10 | 180.00 | 7188 | 997 |
| Comment by chyan [ 02/Sep/24 ] |
|
Looking at the code, the most realistic approach is adding some logging information in the function where the step number is calculated. |
| Comment by chyan [ 12/Sep/24 ] |
|
Ok, I think I also fixed this problem too. Looking at here. This place I try to set the scaling parameter. However, if the convergence loop is stopped due to MCS problem. Those number will not been initiated to correct number until FPS is restarted. So, If we looking at the log, 2024-08-28T04:36:22.121.log, there are several IndexError. Each IndexError will increase the total allowed steps by factor of two. |
| Comment by chyan [ 13/Sep/24 ] |
|
Fix submitted to GitHub |