Instrument control developmentIcon indicating the project type

Instrument control development

Uploaded image for project: 'Instrument control development'
  1. Instrument control development
  2. INSTRM-2336

Cobra commanded step seemed larger than the maximum step

    Details

    • Sprint:
      PostRun18

      Description

      As reported on INSTRM-2328, commanded step size sometimes >2000 (maxTotalSteps), although the maximum number was not changed.

        Attachments

          Issue Links

          relates to

          Task - A task that needs to be done. INSTRM-2376 Implement a better way to handle the unassigned fibers

          • Normal - Normal priorities
          • Open

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            yuki.moritani yuki.moritani added a comment -

            cf) visit=113619 took ~250sec and maximum step is as follows.

            Ite | ang_theta | ang_phi | step_theta | step_phi
0   | 418.95    | 126.36  | 4722 | 1030
1   | 414.80    | 77.84   | 5813 | 1747
2   | 421.98    | 180.00  | 6373 | 1257
3   | 426.32    | 180.00  | 7423 | 1197
4   | 385.61    | 180.00  | 5863 | 1831
5   | 366.06    | 180.82  | 5897 | 987  
6   | 422.81    | 180.00  | 8312 | 686 
7   | 395.10    | 180.00  | 7188 | 997
            Show
            yuki.moritani yuki.moritani added a comment - cf) visit=113619 took ~250sec and maximum step is as follows. Ite | ang_theta | ang_phi | step_theta | step_phi 0 | 418.95 | 126.36 | 4722 | 1030 1 | 414.80 | 77.84 | 5813 | 1747 2 | 421.98 | 180.00 | 6373 | 1257 3 | 426.32 | 180.00 | 7423 | 1197 4 | 385.61 | 180.00 | 5863 | 1831 5 | 366.06 | 180.82 | 5897 | 987  6 | 422.81 | 180.00 | 8312 | 686 7 | 395.10 | 180.00 | 7188 | 997
            Hide
            Permalink
            chyan chyan added a comment -

            Looking at the code, the most realistic approach is adding some logging information in the function where the step number is calculated.

            Show
            chyan chyan added a comment - Looking at the code, the most realistic approach is adding some logging information in the function where the step number is calculated.
            Hide
            Permalink
            chyan chyan added a comment -

            Ok, I think I also fixed this problem too. Looking at here.

            https://github.com/Subaru-PFS/ics_fpsActor/blob/7168fa970db03cfb3f4479cc1dea40507dfc2221/python/ics/fpsActor/Commands/FpsCmd.py#L1355

            This place I try to set the scaling parameter. However, if the convergence loop is stopped due to MCS problem. Those number will not been initiated to correct number until FPS is restarted. So, If we looking at the log, 2024-08-28T04:36:22.121.log, there are several IndexError. Each IndexError will increase the total allowed steps by factor of two.

            Show
            chyan chyan added a comment - Ok, I think I also fixed this problem too. Looking at here. https://github.com/Subaru-PFS/ics_fpsActor/blob/7168fa970db03cfb3f4479cc1dea40507dfc2221/python/ics/fpsActor/Commands/FpsCmd.py#L1355 This place I try to set the scaling parameter. However, if the convergence loop is stopped due to MCS problem. Those number will not been initiated to correct number until FPS is restarted. So, If we looking at the log, 2024-08-28T04:36:22.121.log, there are several IndexError. Each IndexError will increase the total allowed steps by factor of two.
            Hide
            Permalink
            chyan chyan added a comment -

            Fix submitted to GitHub

            Show
            chyan chyan added a comment - Fix submitted to GitHub

              People

              • Assignee:
                chyan chyan
                Reporter:
                yuki.moritani yuki.moritani
              • Votes:
                0 Vote for this issue
                Watchers:
                Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: