[INSTRM-1864] Pass observing info from gen2 to pfsConfig Created: 15/Feb/23 Updated: 21/Feb/23 Resolved: 21/Feb/23 |
|
| Status: | Done |
| Project: | Instrument control development |
| Component/s: | ics_iicActor |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | arnaud.lefur |
| Resolution: | Done | Votes: | 0 |
| Labels: | EngRun | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Sprint: | PreEngRun10Feb | ||||||||
| Description |
|
ics_utils will grow a routine to generate a handful of FITS card for the pfsConfig PHDU. When creating pfsConfig files, retrieve that data and pass it to down to pfsConfig.write() |
| Comments |
| Comment by arnaud.lefur [ 17/Feb/23 ] |
|
so cloomis report that cards will be created like this : cards = getPfsConfigCards(actor, cmd, visit, date=None) price Craig reports that would prefer this argument to be added directly in the constructor. pfsConfig = pfsConfig0.copy(visit=visit) So we would need to add this argument to this method, is that fine with you ? |
| Comment by price [ 17/Feb/23 ] |
|
That method takes **kwargs, so I think you only need to update the constructor. |
| Comment by arnaud.lefur [ 17/Feb/23 ] |
|
right but only for the keys in : keywords = PfsConfig._keywords + PfsConfig._scalars + ['fiberStatus'] If we add the argument name to say PfsConfig_scalars that should indeed work. |
| Comment by price [ 17/Feb/23 ] |
|
Yes, you absolutely need to add header to _scalars. And please be sure to add something to the tests as well. |
| Comment by cloomis [ 17/Feb/23 ] |
|
I think these notes mostly belong in |
| Comment by arnaud.lefur [ 21/Feb/23 ] |
|
merged as iicActor:2.2.10 |