Uploaded image for project: 'DRP 2-D Pipeline'
  1. DRP 2-D Pipeline
  2. PIPE2D-874

Centering/offset/interpolation - fix to PIPE2D 778 and PIPE2D-777

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Done (View Workflow)
    • Priority: Normal
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      4
    • Sprint:
      2DDRP-2021 A 7, 2DDRP-2021 A 8

      Description

      I have realized that the code, as I implemented it in PIPE2D-777 and PIPE2D-778 is wrong. What the code was doing was not summing over the pixel when doing the final downsampling, but just outputing the central value. This was due to me simply copy-pasting the galsim snippet code which correctly applies the offset (interpolating on subpixel values with Lancoz5) and not realizing the difference in this final step. This difference became obvious when using the code provided by Paul in PIPE-872. I have now implemented the proper dowsampling, which is the same as in PIPE-872.

      I have to rerun the solutions being prepared for PIPE2D-857, due to this change (see the Figure). Given that the effect on defocused images and Zernike parameters is minimal, I will run shorter runs as we have to significantly modify only few parameters determining the size in focus.

        Attachments

        1. after_872.png
          81 kB
          ncaplar
        2. before_872.png
          81 kB
          ncaplar

          Issue Links

          blocks

          Task - A task that needs to be done. PIPE2D-857 Apply sky subtraction, deduced from DCB to SuNNS data, for limited number of fibers

          • Normal - Normal priorities
          • Done
          relates to

          Task - A task that needs to be done. PIPE2D-777 Difference in centering between pipeline and 2d algorithm - centering and normalization

          • Normal - Normal priorities
          • Done

          Task - A task that needs to be done. PIPE2D-778 Difference between pipeline and 2d algorithm - interpolation/downsampling

          • Normal - Normal priorities
          • Done

          Task - A task that needs to be done. PIPE2D-872 Expose function resampleKernelImage to python

          • Normal - Normal priorities
          • Done

            Activity

              People

              • Assignee:
                ncaplar ncaplar
                Reporter:
                ncaplar ncaplar
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: