Uploaded image for project: 'DRP 2-D Pipeline'
  1. DRP 2-D Pipeline
  2. PIPE2D-663

Reconsider the API for pfs.drp.stella.fitFocalPlane.FocalPlaneFunction

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done (View Workflow)
    • Priority: Normal
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Sprint:
      2DDRP-2021 A 2

      Description

      In order to return a sky spectrum for fiberId fid the current code looks like:

      pfsSky1D = butler.get('sky1d', dataId)
      sky = pfsSky1D([wavelength], pfsConfig.extractCenters([fid])[0]
      

      The sky spectrum for a given fibre depends on the fibre as well as the position in the focal plane, so I think that we probably want an API more like

      pfsSky1D(pfsConfig, [wavelength], [fid])
      

      An additional semi-trivial point is that it's a little awkward to specify arrays of wavelengths and fiberIds when I want the sky spectrum for a single object. It might be worth adding some syntactic sugar.

        Attachments

          Activity

            People

            • Assignee:
              price price
              Reporter:
              rhl rhl
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: