Uploaded image for project: 'DRP 2-D Pipeline'
  1. DRP 2-D Pipeline
  2. PIPE2D-1305

AdjustDetectorMapTask can raise RuntimeError

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Open (View Workflow)
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      The docs to AdjustDetectorMapTask state that the task raises {{ pfs.drp.stella.fitDistortedDetectorMap.FittingError}} and that's what reduceExposure catches. However, in reality the task raises {{RuntimeError(f"Insufficient good lines:

      {numGoodLines}

      vs

      {needNumLines}

      ")}} which is not caught.

      I'd fix the try block, except that this behaviour is explicitly documented, so I'll leave it up to Paul to decide on the proper fix.

        Attachments

          Activity

            People

            • Assignee:
              price price
              Reporter:
              rhl rhl
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: