Uploaded image for project: 'Instrument control development'
  1. Instrument control development
  2. INSTRM-2578

Handle failures in actorCalls functions

    XMLWordPrintable

    Details

    • Sprint:
      preRun24Sep2025

      Description

      While looking into INSTRM-2573, I noticed there are some errors in the new updateTelStatus that comes from actorCalls.py:

      2025-06-01 14:44:36.998Z actor            20 main.py:101 reply=ag.ag 804 ag F timeout;actor="gen2";cmd="updateTelStatus caller=ag visit=126872"
      2025-06-01 14:44:36.998Z actor            20 main.py:102 didFail=True
      2025-06-01 14:44:36.998Z ag               40 ag.py:437 AgThread.run:
      Traceback (most recent call last):
        File "/software/mhs/products/Linux64/ics_agActor/1.1.26/python/agActor/Controllers/ag.py", line 306, in run
          tel_status = actorCalls.updateTelStatus(self.actor,
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/software/mhs/products/Linux64/ics_agActor/1.1.26/python/agActor/actorCalls.py", line 27, in updateTelStatus
          ).get()
            ^^^^^
        File "/software/mhs/products/Linux64/ics_agActor/1.1.26/python/agActor/main.py", line 104, in get
          raise Exception('command failed: params={}'.format(self.params))
      Exception: command failed: params={'actor': 'gen2', 'cmdStr': 'updateTelStatus caller=ag visit=126872', 'timeLim': 5, 'kwargs': {}}
      

      INSTRM-2573 is about errors in a related self.actor.queueCommand, which has not yet been moved to actorCalls, but will need have exceptions handled similarly once it is moved.

      I'll assign this to myself, but fyi cloomis

        Attachments

          Activity

            People

            • Assignee:
              wtgee Wilfred Gee
              Reporter:
              wtgee Wilfred Gee
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: