-
Type:
Task
-
Status: Done (View Workflow)
-
Priority:
Normal
-
Resolution: Done
-
Component/s: None
-
Labels:
There are three places we use nMatchMin in the McsCmd.py. When fitting outer ring, we use 10% as well as the all fiducial fibers. However, in Eng-20 we found the convergence of cobra gets bad because of bad FF matching. There is discussion on making nMatchMin value higher. The code is attached.
ffid, dist = pfiTransform.updateTransform(mcsData, self.fidsOuterRing, matchRadius=8.0, nMatchMin=0.1) nMatch = len(np.where(ffid > 0)[0]) self.logger.info(f'Matched {nMatch} of {nFidsOuterGood} outer ring fiducial fibres') nsigma = 0 pfiTransform.nsigma = nsigma pfiTransform.alphaRot = 0 self.logger.info(f'Re-calcuating transformation using ALL FFs.') for i in range(2): ffid, dist = pfiTransform.updateTransform(mcsData, self.fidsGood, matchRadius=4.2,nMatchMin=0.1)
- relates to
-
INSTRM-2517 Fiducial Fibers were moved during the convergence
-
- Done
-
-
INSTRM-2487 adding nMatchMin and other parameters to mcs instdata
-
- Done
-