Uploaded image for project: 'Instrument control development'
  1. Instrument control development
  2. INSTRM-2377

Previous pfsConfig0 ignored after re-declaring pfsDesign

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Sprint:
      EngRun18August

      Description

      Although it's uncommon, we sometimes re-declare the same pfsDesign after converging, see the log below :

      2024-06-01 10:16:02.884Z cmds             20 Actor.py:524 new cmd: declareCurrentPfsDesign designId=0x6d832ca291636984                                                          
2024-06-01 10:16:05.595Z cmds             20 Actor.py:524 new cmd: setGratingToDesign                                                                                           
2024-06-01 10:17:41.273Z cmds             20 Actor.py:524 new cmd: moveToPfsDesign exptime=4.8 nIteration=8 tolerance=0.005                                                     
2024-06-01 10:20:35.920Z cmds             20 Actor.py:524 new cmd: acquireField fit_dScale=yes fit_dInR=yes tec_off=no                                                          
2024-06-01 10:20:46.537Z cmds             20 Actor.py:524 new cmd: autoguideStart fit_dScale=yes fit_dInR=yes tec_off=no exptime=3000 cadence=5000                              
2024-06-01 10:21:05.688Z cmds             20 Actor.py:524 new cmd: autoguideStop                                                                                                
2024-06-01 10:24:52.788Z cmds             20 Actor.py:524 new cmd: acquireField exptime=3000 fit_dScale="yes" fit_dInR="yes"                                                    
2024-06-01 10:25:27.687Z cmds             20 Actor.py:524 new cmd: acquireField exptime=3000 fit_dScale="yes" fit_dInR="yes"                                                    
2024-06-01 10:25:49.455Z cmds             20 Actor.py:524 new cmd: autoguideStart exptime=3000 cadence=5000 fit_dScale="yes" fit_dInR="yes" tec_off="no"                        
2024-06-01 10:28:11.818Z cmds             20 Actor.py:524 new cmd: autoguideStop                                                                                                
2024-06-01 10:28:19.199Z cmds             20 Actor.py:524 new cmd: autoguideStop                                                                                                
2024-06-01 10:28:20.188Z cmds             20 Actor.py:524 new cmd: declareCurrentPfsDesign designId=0x6d832ca291636984                                                          
2024-06-01 10:28:23.463Z cmds             20 Actor.py:524 new cmd: setGratingToDesign                                                                                           
2024-06-01 10:29:37.577Z cmds             20 Actor.py:524 new cmd: acquireField fit_dScale=yes fit_dInR=yes tec_off=no                                                          
2024-06-01 10:29:49.319Z cmds             20 Actor.py:524 new cmd: autoguideStart fit_dScale=yes fit_dInR=yes tec_off=no exptime=3000 cadence=5000                              
2024-06-01 10:30:35.599Z cmds             20 Actor.py:524 new cmd: autoguideStop                                                                                                
2024-06-01 10:32:51.470Z cmds             20 Actor.py:524 new cmd: acquireField exptime=3000 fit_dScale="yes" fit_dInR="yes"                                                                                
2024-06-01 10:33:06.362Z cmds             20 Actor.py:524 new cmd: autoguideStart exptime=3000 cadence=5000 fit_dScale="yes" fit_dInR="yes" tec_off="no"                                                    
2024-06-01 10:34:31.883Z cmds             20 Actor.py:524 new cmd: scienceObject exptime=900 duplicate=2 cam=all  name="ga1" forceGrating

      In this case, we did not re-converge. I’ve accounted for this in my code, but there was a bug that caused the previous pfsConfig0 not to be reloaded.

      As a result, the pfsConfig created for the SPS exposure was generated directly from the pfsDesign, leading to pfsConfig.pfiCenter == pfsConfig.pfiNominal, which was unintended.

      Please fix this issue and throw some warnings when this occurs.

        Attachments

          Activity

            People

            • Assignee:
              arnaud.lefur arnaud.lefur
              Reporter:
              arnaud.lefur arnaud.lefur
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: