Instrument control developmentIcon indicating the project type

Instrument control development

Uploaded image for project: 'Instrument control development'
  1. Instrument control development
  2. INSTRM-1864

Pass observing info from gen2 to pfsConfig

    Details

    • Sprint:
      PreEngRun10Feb

      Description

      ics_utils will grow a routine to generate a handful of FITS card for the pfsConfig PHDU. When creating pfsConfig files, retrieve that data and pass it to down to pfsConfig.write()

        Attachments

          Issue Links

          is blocked by

          Task - A task that needs to be done. INSTRM-1863 Add a few FITS header to pfsConfig file

          • Normal - Normal priorities
          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            arnaud.lefur arnaud.lefur added a comment -

            so cloomis report that cards will be created like this :

            cards = getPfsConfigCards(actor, cmd, visit, date=None)

            price Craig reports that would prefer this argument to be added directly in the constructor.
            But I'm actually using the copy method to create the "per-visit" pfsConfig file :

            pfsConfig = pfsConfig0.copy(visit=visit)

            So we would need to add this argument to this method, is that fine with you ?

            Show
            arnaud.lefur arnaud.lefur added a comment - so cloomis report that cards will be created like this : cards = getPfsConfigCards(actor, cmd, visit, date=None) price Craig reports that would prefer this argument to be added directly in the constructor. But I'm actually using the copy method to create the "per-visit" pfsConfig file : pfsConfig = pfsConfig0.copy(visit=visit) So we would need to add this argument to this method, is that fine with you ?
            Hide
            Permalink
            price price added a comment -

            That method takes **kwargs, so I think you only need to update the constructor.

            Show
            price price added a comment - That method takes **kwargs , so I think you only need to update the constructor.
            Hide
            Permalink
            arnaud.lefur arnaud.lefur added a comment -

            right but only for the keys in :

            keywords = PfsConfig._keywords + PfsConfig._scalars + ['fiberStatus']

            If we add the argument name to say PfsConfig_scalars that should indeed work.

            Show
            arnaud.lefur arnaud.lefur added a comment - right but only for the keys in : keywords = PfsConfig._keywords + PfsConfig._scalars + ['fiberStatus'] If we add the argument name to say PfsConfig_scalars that should indeed work.
            Hide
            Permalink
            price price added a comment -

            Yes, you absolutely need to add header to _scalars. And please be sure to add something to the tests as well.

            Show
            price price added a comment - Yes, you absolutely need to add header to _scalars . And please be sure to add something to the tests as well.
            Hide
            Permalink
            cloomis cloomis added a comment -

            I think these notes mostly belong in PIPE2D-1163....

            Show
            cloomis cloomis added a comment - I think these notes mostly belong in PIPE2D-1163 ....
            Hide
            Permalink
            arnaud.lefur arnaud.lefur added a comment -

            merged as iicActor:2.2.10

            Show
            arnaud.lefur arnaud.lefur added a comment - merged as iicActor:2.2.10

              People

              • Assignee:
                arnaud.lefur arnaud.lefur
                Reporter:
                cloomis cloomis
              • Votes:
                0 Vote for this issue
                Watchers:
                Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: