Uploaded image for project: 'Software Development Infrastructure'
  1. Software Development Infrastructure
  2. INFRA-207

Create repo(s) for varying instrument characteristics

    Details

      Description

      [ I am restating this ticket to include more subsystems. It did not make
      sense to only cover detector properties. ]

      We are starting to accrete time-variable data which are required for
      instrument operations, image simulations, and data reductions. I'd
      like to gather a list and see whether we can agree on a small number
      of locations for them. And I propose that by default we save them all
      in a small number of git repos: pfs_instdata for all, or maybe
      spread out to ics_instdata, drp_instdata/obs_pfs,
      ics_cobraData.

      Here are the products I have thought of and a guess as to how often they will
      change. Please propose or directly add any others.

      Product Consumer Variability Data Store Comment
      The MCS and FPS distortion coefficients and interpolation tables FPS, ETS Annual? pfs_instdata Most should be very stable, but we already know that there are annual variations. (See also INSTRM-1240, but that's an opDB table)
      pfsDetectorMaps DRP Field? calib These are expected to vary with time, but we don't yet know how much or how we will encapsulate the changes. As new versions of the full map, or as a basically static map plus perturbations?
      Detector focus motor positions xcuActor Warmup? pfs_instdata These need to be persisted, since we power them down
      Slit hexapod positions enuActor Stable? pfs_instdata These need to be persisted, since we power them down
      Cobra motion maps FPS, ETS Continuously! opDB Almost a silly example.
      Broken cobra list FPS, ETS, DRP Rarely! pfs_instdata Might be worth tracking on its own?
      Cobra x,y of center ETS, DRP Rarely pfs_instdata  
      z-position of science fiber ETS, DRP Rarely pfs_instdata  
      xyz-position of fiducial fiber ETS, DRP Rarely pfs_instdata  
      Broken cable C fibers ETS, DRP Continuously pfs_instdata Already described in broken fiber status bit
      Broken cable B fibers ETS, DRP Continuously pfs_instdata  
      Broken cable A fibers ETS, DRP Continuously pfs_instdata  
      Fiber transmission ETS, DRP Continuously pfs_instdata  INSTRM-1270 (also may address broken fibers above)
      Black dot locations ETS, DRP Continuously pfs_instdata INSTRM-1263, INSTRM-1242 https://github.com/Subaru-PFS/pfs_instdata/blob/master/data/pfi/dot/
      Detector and controller voltages ccdActor, hxActor, agccActor, mcsActor Stable? pfs_instdata H4s will certainly differ. MCS probably not. CCDs? AGCCs?
      Detector defects DRP Stable/Warmup/Regen calib These are currently in obs_pfs. Would they stay there if we had a data product?
      Temperature/cryocooler power setpoints? xcuActor, agccActor   pfs_instdata  
      Amp gains and readnoises? DRP or camera actors Stable calib Are we really putting these in headers?
      Instrument/component "seasons"     YAML After a warmup, or reconfiguration, or other physical change/cycle. I'd like to have a declared and published list. Is this the right place? Possibly covered already by existing mechanisms
      Lamp line lists? DRP   obs_pfs obs_pfs or a data product? Should not change between lamp changes. Note that the simulator wants actual line strengths
      Sky lines DRP   pfs_instdata Currently maintained in obs_pfs
      F-star candidate list DRP Continuously target DB Not quite a calibration product, but needs to be persisted. Location for data still to be determined (INFRA-242)
      AG-PFI transformation matrices ETS Rarely pfs_instdata INSTRM-1037

        Attachments

          Issue Links

            Activity

            Hide
            hassan hassan added a comment -
            Show
            hassan hassan added a comment - Moved to INFRA following guideline specified in https://github.com/Subaru-PFS/doc/blob/master/development-management/request.rst#add-new-github-repository
            Hide
            atsushi.shimono shimono added a comment -

            cloomis do you have any specific idea to be implemented, or say already developed a solid list of repositories??

            Show
            atsushi.shimono shimono added a comment - cloomis do you have any specific idea to be implemented, or say already developed a solid list of repositories??
            Hide
            hassan hassan added a comment - - edited

            After discussing this with cloomis, a single GitHub repository at this stage will suffice.

            It should not be necessary for further repos for the next year or so. If it is determined further repos are necessary, separate JIRA tickets will be raised.

            If this ticket can be addressed quickly this would be appreciated as the need for such a repository is important for MCS and SM1 activities.

            Show
            hassan hassan added a comment - - edited After discussing this with cloomis , a single GitHub repository at this stage will suffice. It should not be necessary for further repos for the next year or so. If it is determined further repos are necessary, separate JIRA tickets will be raised. If this ticket can be addressed quickly this would be appreciated as the need for such a repository is important for MCS and SM1 activities.
            Hide
            cloomis cloomis added a comment -

            To be more specific, we need the MCS/FPS mapping coefficients, the detector/slit motor positions, and the detector voltages now. So can can start with pfs_instdata?

            Show
            cloomis cloomis added a comment - To be more specific, we need the MCS/FPS mapping coefficients, the detector/slit motor positions, and the detector voltages now. So can can start with pfs_instdata ?
            Hide
            hassan hassan added a comment -

            shimono: as discussed yesterday during the PFI/ICS phonecon (2018-08-02), a single GitHub repository pfs_instdata is needed pretty soon. Can you please arrange for this?

            Otherwise please clarify the concerns that you have (I couldn't hear you very well in yesterday's telecon)

            Show
            hassan hassan added a comment - shimono : as discussed yesterday during the PFI/ICS phonecon (2018-08-02), a single GitHub repository pfs_instdata is needed pretty soon. Can you please arrange for this? Otherwise please clarify the concerns that you have (I couldn't hear you very well in yesterday's telecon)
            Hide
            naoyuki.tamura naoyuki.tamura added a comment -

            Hassan, looking at records of the messages from JIRA, I think you have to file a ticket when you request creating a new repository. See INFRA-209, as a recent example.

            All, please correct me if I am saying something incorrect.

             

            Show
            naoyuki.tamura naoyuki.tamura added a comment - Hassan, looking at records of the messages from JIRA, I think you have to file a ticket when you request creating a new repository. See INFRA-209 , as a recent example. All, please correct me if I am saying something incorrect.  
            Hide
            hassan hassan added a comment -

            This issue itself was the request to create that repository, but I see that it may be confusing as it started as a request for multiple repositories, and is now reduced to a single repository. So I will raise a separate ticket to be explicit.

            Show
            hassan hassan added a comment - This issue itself was the request to create that repository, but I see that it may be confusing as it started as a request for multiple repositories, and is now reduced to a single repository. So I will raise a separate ticket to be explicit.
            Hide
            hassan hassan added a comment -

            Created issue INFRA-214 to address the specific request.

            Show
            hassan hassan added a comment - Created issue INFRA-214 to address the specific request.

              People

              • Assignee:
                yuki.moritani yuki.moritani
                Reporter:
                cloomis cloomis
              • Votes:
                0 Vote for this issue
                Watchers:
                Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: