Data ModelIcon indicating the project type

Data Model

Uploaded image for project: 'Data Model'
  1. Data Model
  2. DAMD-13

Change pfsFiberTrace description to persist trace-function coefficients as double

    Details

    • Type: Story
    • Status: Won't Fix (View Workflow)
    • Priority: Major
    • Resolution: Won't Fix
    • Labels:
      None
    • Story Points:
      0.25

      Description

      As shown in PIPE2D-98, the lack of precision in the trace-function coefficients due to only persisting floats is responsible for the difference between the stored FiberTraces and the reconstructed ones. This means that we will have to change the datamodel to persist the trace-function coefficients as double values.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. PIPE2D-98 Add test to confirm that a FiberTraceSet reconstructed from pfsFiberTrace is identical to the original one

          • Major - Major loss of function.
          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. PIPE2D-98 Add test to confirm that a FiberTraceSet reconstructed from pfsFiberTrace is identical to the original one

          • Major - Major loss of function.
          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rhl rhl added a comment -

            Hmm, I am suspicious about needing doubles. The description of this ticket says, "As shown in PIPE2D-98", but I do not see any such demonstration in that ticket, just a comment from swinbank that this might be a problem.

            What basis functions are you using? Polynomials? What is the maximum value of the basis functions (probably 1 as I think you're normalising the range into +-1)? Is there some delicate cancellation? Please investigate why you are losing so much precision as to need doubles before implementing this ticket.

            Show
            rhl rhl added a comment - Hmm, I am suspicious about needing doubles. The description of this ticket says, "As shown in PIPE2D-98 ", but I do not see any such demonstration in that ticket, just a comment from swinbank that this might be a problem. What basis functions are you using? Polynomials? What is the maximum value of the basis functions (probably 1 as I think you're normalising the range into +-1)? Is there some delicate cancellation? Please investigate why you are losing so much precision as to need doubles before implementing this ticket.
            Hide
            Permalink
            swinbank swinbank added a comment -

            Obsoleted by work on PIPE2D-98.

            Show
            swinbank swinbank added a comment - Obsoleted by work on PIPE2D-98 .

              People

              • Assignee:
                Unassigned
                Reporter:
                aritter aritter
              • Votes:
                0 Vote for this issue
                Watchers:
                Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: