https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/SIM2D-94 DRP 2-D Simulator <p>The Simulator has the capability of reading a library of spectra, but the association between fibers and spectra is currently random. In order to simulate a survey, the user should provide a <tt>PfsConfig</tt> to the Simulator, which it then implements.<br/> This requires:</p> <ul> <li>Modifying the front-end of the Simulator to accept a <tt>PfsConfig</tt></li> <li>Providing a facility to construct a <tt>PfsConfig</tt> (random assignment) for the user who doesn't want to run a full simulated survey targeting program.</li> </ul> SIM2D-94

Simulator should accept a PfsConfig instance

Story Normal Done Done price price Tue, 29 Jan 2019 16:02:49 +0000 Wed, 13 Mar 2019 19:52:25 +0000 Wed, 13 Mar 2019 18:55:27 +0000 6.0 0 2 <p>Also, create the blue and red images as part of the same command.</p> <p>Actually, we want the simulator to accept a <tt>PfiDesign</tt>; this is kinda how the actual instrument works too.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a>, I believe this is done; I'll do some more testing on Monday.</p> <p>I've made the modifications to the simulator. There's also a minor addition to <tt>PfsConfig</tt> in datamodel and a bugfix there too, just because I spotted it. The changes in pfs_instmodel are based off <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-316" title="Demonstrate arm merging" class="issue-link" data-issue-key="PIPE2D-316"><del>PIPE2D-316</del></a>.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> price@MacBook:~/pfs/datamodel (tickets/SIM2D-94=) $ git sub commit e5f9193c3694baef9195c99f4e53d7605c4d1db8 Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Wed Feb 20 15:54:10 2019 -0500 PfsSpectra: fix plotting Was attempting to iterate over multiple arrays withing zipping them. python/pfs/datamodel/pfsSpectra.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit da266024310c3564a9801ffba3278549ca844513 Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Wed Feb 20 18:27:14 2019 -0500 git: ignore test side effect .gitignore | 1 + 1 file changed, 1 insertion(+) commit 80ecb2918596f246df9f5cddce043616280e72ac (HEAD -&gt; tickets/SIM2D-94, origin/tickets/SIM2D-94) Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Thu Feb 21 15:23:48 2019 -0500 add PfsConfig.fromPfiDesign Construct a PfsConfig given a PfiDesign and a couple of other bits. python/pfs/datamodel/pfsConfig.py | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) price@MacBook:~/pfs/drp_instmodel (tickets/SIM2D-94 %=) $ git sub tickets/SIM2D-94 origin/tickets/PIPE2D-316 commit 210807152bd423cef1be439c7647a40c8a3c71b3 (HEAD -&gt; tickets/SIM2D-94, origin/tickets/SIM2D-94, tickets/PIPE2D-316) Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Thu Feb 21 20:55:45 2019 -0500 split makeSim into makePfiDesign+makeSim In order to create multiple arms with the same fiber assignments, we want makeSim to receive a PfiDesign (that's kinda how the actual instrument will work too!). So now you first makePfiDesign, and then use that PfiDesign in makeSim. In the process, did some reorganisation (<span class="code-quote">"python/pfs_instmodel"</span> --&gt; <span class="code-quote">"python/pfs/instmodel"</span>; remove <span class="code-quote">"examples"</span> directory and rename sampleField.py to fieldDefinitions.py); sorry to include these here, but it was difficult to split out after having done the work. bin/makePfiDesign | 1 + bin/makeSimRun | 75 +++++----- .../{pfs_instmodel =&gt; pfs/instmodel}/__init__.py | 0 .../{pfs_instmodel =&gt; pfs/instmodel}/detector.py | 0 .../{pfs_instmodel =&gt; pfs/instmodel}/exposure.py | 0 python/pfs/instmodel/fieldDefinitions.py | 87 ++++++++++++ .../{pfs_instmodel =&gt; pfs/instmodel}/jegSpots.py | 0 python/pfs/instmodel/makePfiDesign.py | 51 +++++++ .../instmodel}/makePfsConfig.py | 117 ++++++++-------- python/{pfs_instmodel =&gt; pfs/instmodel}/makeSim.py | 35 ++--- .../{pfs_instmodel =&gt; pfs/instmodel}/plotutils.py | 0 python/{pfs_instmodel =&gt; pfs/instmodel}/probe.py | 0 python/{pfs_instmodel =&gt; pfs/instmodel}/psf.py | 0 python/pfs/instmodel/readme.txt | 154 +++++++++++++++++++++ .../examples =&gt; pfs/instmodel/schema}/__init__.py | 0 .../instmodel}/schema/probes.py | 0 .../{pfs_instmodel =&gt; pfs/instmodel}/simImage.py | 6 +- python/{pfs_instmodel =&gt; pfs/instmodel}/sky.py | 0 python/{pfs_instmodel =&gt; pfs/instmodel}/slit.py | 0 python/{pfs_instmodel =&gt; pfs/instmodel}/specMap.py | 0 .../{pfs_instmodel =&gt; pfs/instmodel}/spectrum.py | 0 .../instmodel}/spectrumLibrary.py | 0 .../{pfs_instmodel =&gt; pfs/instmodel}/splinedPsf.py | 8 ++ .../{pfs_instmodel =&gt; pfs/instmodel}/spotgames.py | 2 +- .../instmodel}/utils/SeqPath.py | 0 .../instmodel}/utils/__init__.py | 0 .../instmodel}/utils/blackbody.py | 0 .../instmodel}/utils/centroid.py | 0 .../instmodel}/utils/configFile.py | 0 .../instmodel}/utils/generators.py | 0 .../{pfs_instmodel =&gt; pfs/instmodel}/utils/geom.py | 0 .../instmodel}/utils/pydebug.py | 0 .../instmodel}/utils/rebin.py | 0 .../instmodel}/utils/schema.py | 0 .../{pfs_instmodel =&gt; pfs/instmodel}/zemaxSpots.py | 0 python/pfs_instmodel/examples/sampleField.py | 77 ----------- python/pfs_instmodel/schema/__init__.py | 0 37 files changed, 418 insertions(+), 195 deletions(-) </pre> </div></div> <p>I've added GitHub PRs for datamodel and drp_instmodel. The latter includes related work that gets the simulator working on the blue arm.</p> <p>Comment made by <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> during review moved to a separate ticket (<a href="https://pfspipe.ipmu.jp/jira/browse/SIM2D-109" title="Refactor code such that PfsConfigs are not dark/flat/science specific" class="issue-link" data-issue-key="SIM2D-109"><del>SIM2D-109</del></a>).</p> <p>Merged to master.</p> Blocks PIPE2D-316 Relates SIM2D-109 Development Rank 0|02qpt6:508yjj49 Reviewers hassan Sprint 2019 B 2DDRP-2019 C Story Points 5.0