https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/SIM2D-31 DRP 2-D Simulator <p>The flat field lamps will be incandescent lamps with a filter to approximate a black body at c. 5000K.</p> SIM2D-31

Simulate flat field lamp spectra

Story Major Done Done price rhl Tue, 15 Jul 2014 22:39:46 +0000 Wed, 18 Sep 2019 17:39:47 +0000 Wed, 18 Sep 2019 17:39:47 +0000 0 4 <p>Just needed to adjust the temperature. The changes are trivial:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> price@price-laptop:~/pfs/drp_instmodel (tickets/SIM2D-31 *$%=) $ git sub-patch commit ce712b0cde22da128e6be9e8492e7da875017fb8 (HEAD -&gt; tickets/SIM2D-31, origin/tickets/SIM2D-31) Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Wed Sep 11 12:45:49 2019 -0400 FlatSpectrum: set temperature to 5000 K as specfied by RHL. This requires a slight adjustment of the scaling as well to avoid saturating the detectors. diff --git a/python/pfs/instmodel/spectrum.py b/python/pfs/instmodel/spectrum.py index a190431..ffdabea 100644 --- a/python/pfs/instmodel/spectrum.py +++ b/python/pfs/instmodel/spectrum.py @@ -173,12 +173,12 @@ <span class="code-keyword">class </span>FlatSpectrum(Spectrum): scale : `<span class="code-object">float</span>` Scale to apply to spectrum. """ - def __init__(self, scale=2.0e-19): # Scale chosen manually to get reasonable counts in 30 sec + def __init__(self, scale=7.0e-20): # Scale chosen manually to get reasonable counts in 30 sec self.scale = scale def interpolate(self, wavelength): <span class="code-quote">"""<span class="code-keyword">return</span> a quartz lamp spectrum, as seen by our detector."</span>"" - <span class="code-keyword">return</span> self.scale*blackbody(wavelength, 3800.0) + <span class="code-keyword">return</span> self.scale*blackbody(wavelength, 5000.0) <span class="code-keyword">class </span>LineSpectrum(Spectrum): </pre> </div></div> <p>Changes look fine from the diff. But you don't want to raise a pull request?</p> <p>The changes are trivial, and the diff is pasted above. Do you need a GitHub PR?</p> <p>No, your approach is fine for this one. I should have made that clear in my last message. I'll mark this as review-complete.</p> <p>Merged to master.</p> Blocks INFRA-4 Development Epic Link SIM2D-27 Rank 0|034560: Reviewers hassan