<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:09:03 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[SIM2D-146] Dichroic model is inconsistent between blue and red</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/SIM2D-146</link>
                <project id="10000" key="SIM2D">DRP 2-D Simulator</project>
                    <description>&lt;p&gt;The dichroic throughputs from &lt;tt&gt;pfs&amp;#95;thr&amp;#95;20201231&amp;#95;ext&amp;#95;all&amp;#95;&amp;#42;.dat&lt;/tt&gt; have a sum that exceeds unity, which is unphysical.&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/14534/14534_dichroic.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
&lt;span class=&quot;code-keyword&quot;&gt;import&lt;/span&gt; numpy as np
&lt;span class=&quot;code-keyword&quot;&gt;import&lt;/span&gt; matplotlib.pyplot as plt
blueData = np.genfromtxt(&lt;span class=&quot;code-quote&quot;&gt;&quot;../drp_instdata/data/throughput/pfs_thr_20201231_ext_all_blu.dat&quot;&lt;/span&gt;)
redData = np.genfromtxt(&lt;span class=&quot;code-quote&quot;&gt;&quot;../drp_instdata/data/throughput/pfs_thr_20201231_ext_all_red.dat&quot;&lt;/span&gt;)
wavelength = np.concatenate((blueData[:2600, 0], redData[:, 0]))
&lt;span class=&quot;code-keyword&quot;&gt;assert&lt;/span&gt;(np.all(blueData[2600:, 0] == redData[:401, 0]))
blue = np.zeros_like(wavelength)
blue[:3001] = blueData[:, 5]
red = np.zeros_like(wavelength)
red[2600:] = redData[:, 5]
total = blue + red
plt.plot(wavelength, blue, &lt;span class=&quot;code-quote&quot;&gt;&quot;b-&quot;&lt;/span&gt;)
plt.plot(wavelength, red, &lt;span class=&quot;code-quote&quot;&gt;&quot;r-&quot;&lt;/span&gt;)
plt.plot(wavelength, total, &lt;span class=&quot;code-quote&quot;&gt;&quot;k-&quot;&lt;/span&gt;)
plt.xlabel(&lt;span class=&quot;code-quote&quot;&gt;&quot;Wavelength (nm)&quot;&lt;/span&gt;)
plt.ylabel(&lt;span class=&quot;code-quote&quot;&gt;&quot;Dichroic transmission&quot;&lt;/span&gt;)
plt.suptitle(&lt;span class=&quot;code-quote&quot;&gt;&quot;pfs_thr_20201231_ext_all_*.dat&quot;&lt;/span&gt;)
plt.show()
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</description>
                <environment></environment>
        <key id="22563">SIM2D-146</key>
            <summary>Dichroic model is inconsistent between blue and red</summary>
                <type id="10001" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10515&amp;avatarType=issuetype">Story</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="kiyoto.yabe">Kiyoto Yabe</assignee>
                                    <reporter username="price">price</reporter>
                        <labels>
                    </labels>
                <created>Thu, 16 Dec 2021 19:41:19 +0000</created>
                <updated>Wed, 22 Dec 2021 00:17:49 +0000</updated>
                            <resolved>Wed, 22 Dec 2021 00:17:49 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                <comments>
                            <comment id="30232" author="kiyoto.yabe" created="Tue, 21 Dec 2021 08:10:31 +0000"  >&lt;p&gt;I just upload the new version (pfs_thr_20211220_ext_all_*.dat) to `drp_instdata`. The cause is that the reflectance of the blue dichroic used for the estimation is taken from the datasheet of the &quot;witness sample&quot;. I could not find the proper estimation for the reflectance, so assume that reflectance = 1 - transmittance, but note that the absorption documented is 3-4% in average and might be severer in bluer part. Anyway, the updated version does not show any tip at the transition wavelength when blue and red are combined.&#160;&lt;/p&gt;</comment>
                            <comment id="30234" author="price" created="Tue, 21 Dec 2021 17:23:28 +0000"  >&lt;p&gt;It looks like that with the new curves, the dichroic cutoff in the blue arm has moved 15 nm to shorter wavelengths, and the ripples on the blue arm have disappeared.&lt;br/&gt;
Comparing the ripples in the old curves with quartz spectra from PFI, I estimated the shift was about 10 nm.&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/15061/15061_sim2d-146.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;/p&gt;

&lt;p&gt;I confirmed that the NIR is unaffected.&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/15063/15063_sim2d-146-nir.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
&lt;span class=&quot;code-keyword&quot;&gt;import&lt;/span&gt; numpy as np
&lt;span class=&quot;code-keyword&quot;&gt;import&lt;/span&gt; matplotlib.pyplot as plt
blueData = np.genfromtxt(&lt;span class=&quot;code-quote&quot;&gt;&quot;../drp_instdata/data/throughput/pfs_thr_20201231_ext_all_blu.dat&quot;&lt;/span&gt;)
redData = np.genfromtxt(&lt;span class=&quot;code-quote&quot;&gt;&quot;../drp_instdata/data/throughput/pfs_thr_20201231_ext_all_red.dat&quot;&lt;/span&gt;)
nirData = np.genfromtxt(&lt;span class=&quot;code-quote&quot;&gt;&quot;../drp_instdata/data/throughput/pfs_thr_20201231_ext_all_nir.dat&quot;&lt;/span&gt;)
&lt;span class=&quot;code-keyword&quot;&gt;assert&lt;/span&gt;(np.all(blueData[2600:, 0] == redData[:401, 0]))
&lt;span class=&quot;code-keyword&quot;&gt;assert&lt;/span&gt;(np.all(redData[3150:, 0] == nirData[:401, 0]))
wavelength = np.concatenate((blueData[:2600, 0], redData[:, 0], nirData[401:, 0]))
blue = np.zeros_like(wavelength)
blue[:3001] = blueData[:, 9]
red = np.zeros_like(wavelength)
red[2600:6151] = redData[:, 9]
nir = np.zeros_like(wavelength)
nir[5750:] = nirData[:, 9]
total = blue + red + nir
plt.plot(wavelength, blue, &lt;span class=&quot;code-quote&quot;&gt;&quot;b:&quot;&lt;/span&gt;)
plt.plot(wavelength, red, &lt;span class=&quot;code-quote&quot;&gt;&quot;g:&quot;&lt;/span&gt;)
plt.plot(wavelength, nir, &lt;span class=&quot;code-quote&quot;&gt;&quot;r:&quot;&lt;/span&gt;)
plt.plot(wavelength, total, &lt;span class=&quot;code-quote&quot;&gt;&quot;k:&quot;&lt;/span&gt;, label=&lt;span class=&quot;code-quote&quot;&gt;&quot;Old&quot;&lt;/span&gt;)
blueData = np.genfromtxt(&lt;span class=&quot;code-quote&quot;&gt;&quot;../drp_instdata/data/throughput/pfs_thr_20211220_ext_all_blu.dat&quot;&lt;/span&gt;)
redData = np.genfromtxt(&lt;span class=&quot;code-quote&quot;&gt;&quot;../drp_instdata/data/throughput/pfs_thr_20211220_ext_all_red.dat&quot;&lt;/span&gt;)
nirData = np.genfromtxt(&lt;span class=&quot;code-quote&quot;&gt;&quot;../drp_instdata/data/throughput/pfs_thr_20211220_ext_all_nir.dat&quot;&lt;/span&gt;)
&lt;span class=&quot;code-keyword&quot;&gt;assert&lt;/span&gt;(np.all(blueData[2600:, 0] == redData[:401, 0]))
&lt;span class=&quot;code-keyword&quot;&gt;assert&lt;/span&gt;(np.all(redData[3150:, 0] == nirData[:401, 0]))
wavelength = np.concatenate((blueData[:2600, 0], redData[:, 0], nirData[401:, 0]))
blue = np.zeros_like(wavelength)
blue[:3001] = blueData[:, 9]
red = np.zeros_like(wavelength)
red[2600:6151] = redData[:, 9]
nir = np.zeros_like(wavelength)
nir[5750:] = nirData[:, 9]
total = blue + red + nir
plt.plot(wavelength, blue, &lt;span class=&quot;code-quote&quot;&gt;&quot;b-&quot;&lt;/span&gt;)
plt.plot(wavelength, red, &lt;span class=&quot;code-quote&quot;&gt;&quot;g-&quot;&lt;/span&gt;)
plt.plot(wavelength, nir, &lt;span class=&quot;code-quote&quot;&gt;&quot;r-&quot;&lt;/span&gt;)
plt.plot(wavelength, total, &lt;span class=&quot;code-quote&quot;&gt;&quot;k-&quot;&lt;/span&gt;, label=&lt;span class=&quot;code-quote&quot;&gt;&quot;New&quot;&lt;/span&gt;)
plt.xlabel(&lt;span class=&quot;code-quote&quot;&gt;&quot;Wavelength (nm)&quot;&lt;/span&gt;)
plt.ylabel(&lt;span class=&quot;code-quote&quot;&gt;&quot;Transmission&quot;&lt;/span&gt;)
plt.legend()
plt.suptitle(&lt;span class=&quot;code-quote&quot;&gt;&quot;Old vs New&quot;&lt;/span&gt;)
plt.show()
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</comment>
                            <comment id="30235" author="price" created="Tue, 21 Dec 2021 19:08:03 +0000"  >&lt;p&gt;I&apos;ve updated the simulator to use the new throughput curves provided by &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=kiyoto.yabe&quot; class=&quot;user-hover&quot; rel=&quot;kiyoto.yabe&quot;&gt;Kiyoto Yabe&lt;/a&gt;.&lt;/p&gt;</comment>
                            <comment id="30238" author="hassan" created="Tue, 21 Dec 2021 23:26:45 +0000"  >&lt;p&gt;No objections with suggested changes in pull requests.&lt;/p&gt;</comment>
                            <comment id="30239" author="price" created="Wed, 22 Dec 2021 00:17:49 +0000"  >&lt;p&gt;Thanks, &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=kiyoto.yabe&quot; class=&quot;user-hover&quot; rel=&quot;kiyoto.yabe&quot;&gt;Kiyoto Yabe&lt;/a&gt; and &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan&quot; class=&quot;user-hover&quot; rel=&quot;hassan&quot;&gt;hassan&lt;/a&gt;.&lt;/p&gt;

&lt;p&gt;Merged to master.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="14534" name="dichroic.png" size="32463" author="price" created="Thu, 16 Dec 2021 19:38:43 +0000"/>
                            <attachment id="15060" name="dichroic_revised.png" size="31145" author="kiyoto.yabe" created="Tue, 21 Dec 2021 08:00:02 +0000"/>
                            <attachment id="15063" name="sim2d-146-nir.png" size="47138" author="price" created="Tue, 21 Dec 2021 17:24:26 +0000"/>
                            <attachment id="15061" name="sim2d-146.png" size="42142" author="price" created="Tue, 21 Dec 2021 17:09:51 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|02qpt6:508yl0chzzy0000q01r3609</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>hassan</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>