<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:08:58 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[SIM2D-139] Simulator fails with TypeError</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/SIM2D-139</link>
                <project id="10000" key="SIM2D">DRP 2-D Simulator</project>
                    <description>&lt;p&gt;When running the simulator, eg with the command:&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
makeSim --visit 47 --detector r1  --pfsDesignId 1 --exptime 1800 --type object
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;The simulator fails with the following error:&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
Traceback (most recent call last):
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/tigress/HSC/PFS/stack/current/python/miniconda3-4.5.12/envs/lsst-scipipe/lib/python3.7/runpy.py&quot;&lt;/span&gt;, line 193, in _run_module_as_main
    &lt;span class=&quot;code-quote&quot;&gt;&quot;__main__&quot;&lt;/span&gt;, mod_spec)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/tigress/HSC/PFS/stack/current/python/miniconda3-4.5.12/envs/lsst-scipipe/lib/python3.7/runpy.py&quot;&lt;/span&gt;, line 85, in _run_code
    exec(code, run_globals)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/tigress/hassans/software/drp_instmodel/python/pfs/instmodel/makeSim.py&quot;&lt;/span&gt;, line 308, in &amp;lt;module&amp;gt;
    main()
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/tigress/hassans/software/drp_instmodel/python/pfs/instmodel/makeSim.py&quot;&lt;/span&gt;, line 275, in main
    logger=logger)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/tigress/hassans/software/drp_instmodel/python/pfs/instmodel/makeSim.py&quot;&lt;/span&gt;, line 88, in makeSim
    spectra = [source.getSpectrum(fiberId) &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; fiberId in fibers]
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/tigress/hassans/software/drp_instmodel/python/pfs/instmodel/makeSim.py&quot;&lt;/span&gt;, line 88, in &amp;lt;listcomp&amp;gt;
    spectra = [source.getSpectrum(fiberId) &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; fiberId in fibers]
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/tigress/hassans/software/drp_instmodel/python/pfs/instmodel/lightSource.py&quot;&lt;/span&gt;, line 164, in getSpectrum
    target = self.getTargetData(fiberId)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/tigress/hassans/software/drp_instmodel/python/pfs/instmodel/lightSource.py&quot;&lt;/span&gt;, line 216, in getTargetData
    &lt;span class=&quot;code-keyword&quot;&gt;assert&lt;/span&gt; len(index) == 1
TypeError: object of type &lt;span class=&quot;code-quote&quot;&gt;&apos;&lt;span class=&quot;code-object&quot;&gt;int&lt;/span&gt;&apos;&lt;/span&gt; has no len()
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</description>
                <environment></environment>
        <key id="16913">SIM2D-139</key>
            <summary>Simulator fails with TypeError</summary>
                <type id="1" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10503&amp;avatarType=issuetype">Bug</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="hassan">hassan</assignee>
                                    <reporter username="hassan">hassan</reporter>
                        <labels>
                    </labels>
                <created>Mon, 28 Jun 2021 22:30:28 +0000</created>
                <updated>Tue, 29 Jun 2021 00:47:51 +0000</updated>
                            <resolved>Tue, 29 Jun 2021 00:47:51 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>1</watches>
                                                                <comments>
                            <comment id="21593" author="hassan" created="Mon, 28 Jun 2021 22:38:08 +0000"  >&lt;p&gt;Problem seems to be a consequence of the changes made in &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/browse/PIPE2D-762&quot; title=&quot;pfsConfig.selectFiber returns a transposed array with an extra dimension&quot; class=&quot;issue-link&quot; data-issue-key=&quot;PIPE2D-762&quot;&gt;&lt;del&gt;PIPE2D-762&lt;/del&gt;&lt;/a&gt;. With the changes made there, the return value of pfsDesign.selectFiber(fiberId) can now be a scalar as well as a sequence. A scalar return value its currently not supported in the 2D simulator (specifically lightSource.py), resulting in the failure.&lt;/p&gt;</comment>
                            <comment id="21596" author="hassan" created="Tue, 29 Jun 2021 00:47:51 +0000"  >&lt;p&gt;Merged to master.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|zzs8fc:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>price</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10002" key="com.atlassian.jira.plugin.system.customfieldtypes:float">
                        <customfieldname>Story Points</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                        </customfields>
    </item>
</channel>
</rss>