https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/SIM2D-109 DRP 2-D Simulator <p>Following <a href="https://pfspipe.ipmu.jp/jira/browse/SIM2D-94" title="Simulator should accept a PfsConfig instance" class="issue-link" data-issue-key="SIM2D-94"><del>SIM2D-94</del></a> it was noticed that there is code in <tt>makePfsConfig.py</tt> to make flat or dark-specific <tt>PfsConfig</tt> s. </p> <p>As <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> had remarked in PR #3 for the above issue:</p> <blockquote><p>I do not think that <tt>pfsConfig</tt> can or should hold any information about what light goes through a fiber by declaring <tt>makeFlatConfig</tt>, <tt>makeDarkConfig</tt>, etc. The design tells where the cobras are pointed (which can be behind a spot), but that same config is used for taking darks, arcs, flats, and science exposures.</p></blockquote> <p>Please make the generated <tt>pfsConfigs</tt> independent of flats, darks or science.</p> SIM2D-109

Refactor code such that PfsConfigs are not dark/flat/science specific

Task Normal Done Done price hassan Thu, 7 Mar 2019 18:18:40 +0000 Fri, 5 Apr 2019 12:01:19 +0000 Fri, 5 Apr 2019 05:59:57 +0000 0 2 <p>I can imagine a flag in the <tt>pfsDesign</tt> to say if a fibre is behind a spot.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a>, would you please have a look?</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> price@MacBook:~/pfs/drp_instmodel (tickets/SIM2D-109=) $ git sub commit 7c1ffeb8b9c19cc7339dd806c0449efb4786118f Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Tue Mar 19 12:29:56 2019 -0400 convert to pfsDesign+light source as specifying spectra I was using the pfsDesign to specify the spectra, even <span class="code-keyword">for</span> arcs and darks, but the pfsDesign should only specify the top-end configuration, and the light source (sky vs quartz vs arc vs dark) should be separate. This allows us to dispense with the field definitions. bin/makeSimRun | 79 ++++----- python/pfs/instmodel/fieldDefinitions.py | 87 ---------- python/pfs/instmodel/lightSource.py | 288 +++++++++++++++++++++++++++++++ python/pfs/instmodel/makePfiDesign.py | 64 ++++--- python/pfs/instmodel/makePfsConfig.py | 169 +----------------- python/pfs/instmodel/makeSim.py | 38 ++-- python/pfs/instmodel/spectrumLibrary.py | 122 ------------- 7 files changed, 383 insertions(+), 464 deletions(-) commit 53e348f6a3b392ceb2f72606c2a85d51e14bad05 (HEAD -&gt; tickets/SIM2D-109, origin/tickets/SIM2D-109) Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Tue Mar 19 15:28:35 2019 -0400 add SumSpectrum Not using it yet, but it might be useful down the road. python/pfs/instmodel/spectrum.py | 45 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) </pre> </div></div> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> has commented on pull request and is happy with the changes.</p> <p>Created <a href="https://pfspipe.ipmu.jp/jira/browse/SIM2D-116" title="Simplify makeSim arguments" class="issue-link" data-issue-key="SIM2D-116"><del>SIM2D-116</del></a> to clean up the arguments, as <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> suggested.</p> <p>Merged to master.</p> Relates SIM2D-94 Development Rank 0|02qpt6:508yjj0k Reviewers cloomis Sprint 2DDRP-2019 C Story Points 4.0