[REDMINE1D-43] [RM-6106] Discussion: minimal number of peaks to keep with CExtremum::Find

Tue, 13 Jun 2023 06:12:16 +0000

Created on 2020-11-06 12:55:15 by Mira Sarkis. % Done: 0

Currently with develop0.14, the minimal number of peaks is set to 2 in CExtremum::Find.

We decided to pass it 1 in the context of issue #6051 where we privilige vicinity cut over meritCut.
If meritCut returns two peaks that are very close, we eliminate the one with lower PDF.

Didier states that a minimal number of Peaks is only meaningful when using relative metrics, i.e., comparing two peak metrics to each other (e.g., comparing PDF values).

If we decide to use non-relative metric (#5625), e.g., DtD = cte and compare peak merits to this value, we could face cases where this metric eliminates all the pdf peaks (thus eliminating Euclid spurious ??). In this case, does it have a meaning to force keeping 2 or even 1 peak? Wouldnt be more beneficial to throw an error in such a case?

PFS-JIRA

[REDMINE1D-43] [RM-6106] Discussion: minimal number of peaks to keep with CExtremum::Find