<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 15:31:55 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[REDMINE1D-358] [RM-8484] invalid parameters file in full IT</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/REDMINE1D-358</link>
                <project id="11002" key="REDMINE1D">1D Redmine </project>
                    <description>&lt;p&gt;&lt;em&gt;&lt;font color=&quot;#505f79&quot;&gt; Created on 2023-11-15 15:34:33 by Pierre-yves Chabaud. % Done: 100&lt;/font&gt;&lt;/em&gt;&lt;/p&gt;


&lt;p&gt;There is an invalid parameters file in @linemeas_rules_balmersingle@ IT (part of full IT) :&lt;/p&gt;

&lt;p&gt;&amp;lt;pre&amp;gt;&lt;br/&gt;
Traceback (most recent call last):                                            &lt;br/&gt;
  File &quot;/net/CESAM/amazed/pychabau/venv/amazedpy3.9/lib64/python3.9/site-packages/pylibamazed/ParametersChecker.py&quot;, line 73, in json_schema_check&lt;br/&gt;
    validate(instance=self.accessor.parameters, schema=self.jsonSchema, resolver=resolver)           &lt;br/&gt;
  File &quot;/net/CESAM/amazed/venvs/amazed_shared_3.9_v1.0/lib/python3.9/site-packages/jsonschema/validators.py&quot;, line 1121, in validate&lt;br/&gt;
    raise error                                                               &lt;br/&gt;
jsonschema.exceptions.ValidationError: &apos;balmersingle&apos; is not one of &lt;span class=&quot;error&quot;&gt;&amp;#91;&amp;#39;all&amp;#39;, &amp;#39;no&amp;#39;, &amp;#39;strongweak&amp;#39;, &amp;#39;balmerSingle&amp;#39;, &amp;#39;ratiorange&amp;#39;&amp;#93;&lt;/span&gt;&lt;/p&gt;

&lt;p&gt;Failed validating &apos;enum&apos; in schema&lt;span class=&quot;error&quot;&gt;&amp;#91;&amp;#39;properties&amp;#39;&amp;#93;&lt;/span&gt;&lt;span class=&quot;error&quot;&gt;&amp;#91;&amp;#39;galaxy&amp;#39;&amp;#93;&lt;/span&gt;&lt;span class=&quot;error&quot;&gt;&amp;#91;&amp;#39;properties&amp;#39;&amp;#93;&lt;/span&gt;&lt;span class=&quot;error&quot;&gt;&amp;#91;&amp;#39;LineMeasSolve&amp;#39;&amp;#93;&lt;/span&gt;&lt;span class=&quot;error&quot;&gt;&amp;#91;&amp;#39;properties&amp;#39;&amp;#93;&lt;/span&gt;&lt;span class=&quot;error&quot;&gt;&amp;#91;&amp;#39;linemodel&amp;#39;&amp;#93;&lt;/span&gt;&lt;span class=&quot;error&quot;&gt;&amp;#91;&amp;#39;properties&amp;#39;&amp;#93;&lt;/span&gt;&lt;span class=&quot;error&quot;&gt;&amp;#91;&amp;#39;rules&amp;#39;&amp;#93;&lt;/span&gt;:&lt;/p&gt;
    {&apos;description&apos;: &apos;Selects used rules (only for `lineRatioType=rules`)&apos;,         
     &apos;enum&apos;: [&apos;all&apos;, &apos;no&apos;, &apos;strongweak&apos;, &apos;balmerSingle&apos;, &apos;ratiorange&apos;],                                                       
     &apos;title&apos;: &apos;Rules&apos;,                                                                       
     &apos;type&apos;: &apos;string&apos;}                                                                                                        

&lt;p&gt;On instance&lt;span class=&quot;error&quot;&gt;&amp;#91;&amp;#39;galaxy&amp;#39;&amp;#93;&lt;/span&gt;&lt;span class=&quot;error&quot;&gt;&amp;#91;&amp;#39;LineMeasSolve&amp;#39;&amp;#93;&lt;/span&gt;&lt;span class=&quot;error&quot;&gt;&amp;#91;&amp;#39;linemodel&amp;#39;&amp;#93;&lt;/span&gt;&lt;span class=&quot;error&quot;&gt;&amp;#91;&amp;#39;rules&amp;#39;&amp;#93;&lt;/span&gt;:                                                                &lt;br/&gt;
    &apos;balmersingle&apos;  &lt;br/&gt;
&amp;lt;/pre&amp;gt;&lt;/p&gt;</description>
                <environment></environment>
        <key id="24206">REDMINE1D-358</key>
            <summary>[RM-8484] invalid parameters file in full IT</summary>
                <type id="3" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10518&amp;avatarType=issuetype">Task</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="r2j.migrate">Redmine-Jira Migtation</assignee>
                                    <reporter username="r2j.migrate">Redmine-Jira Migtation</reporter>
                        <labels>
                    </labels>
                <created>Wed, 15 Nov 2023 18:15:38 +0000</created>
                <updated>Mon, 27 Nov 2023 18:22:59 +0000</updated>
                            <resolved>Mon, 27 Nov 2023 18:22:59 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>1</watches>
                                                                <comments>
                            <comment id="36136" author="r2j.migrate" created="Mon, 27 Nov 2023 18:20:35 +0000"  >&lt;p&gt;Comment by Fanny Dufresne on 2023-11-16 12:26:34:&lt;br/&gt;
MR dataset parameters: &lt;a href=&quot;https://gitlab.lam.fr/amazed/dataset-parameters/-/merge_requests/70&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;https://gitlab.lam.fr/amazed/dataset-parameters/-/merge_requests/70&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;MR cpf redshift &lt;a href=&quot;https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/566&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/566&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="36137" author="r2j.migrate" created="Mon, 27 Nov 2023 18:20:46 +0000"  >&lt;p&gt;Comment by Didier Vibert on 2023-11-17 11:44:48:&lt;br/&gt;
cf gitlab comment on  cpf redshift MR &lt;a href=&quot;https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/566&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/566&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="36138" author="r2j.migrate" created="Mon, 27 Nov 2023 18:20:54 +0000"  >&lt;p&gt;Comment by Didier Vibert on 2023-11-17 12:29:34:&lt;br/&gt;
pour info, @fdufresne j&apos;ai copi&#233; ton rep d&apos;output &lt;br/&gt;
&amp;lt;pre&amp;gt;&lt;br/&gt;
/net/CESAM/amazed/fdufresne/it/fix_issue_8484/2677c97c_b4f9b12_17190ac&lt;br/&gt;
&amp;lt;/pre&amp;gt; &lt;br/&gt;
dans &lt;br/&gt;
&amp;lt;pre&amp;gt;&lt;br/&gt;
/net/CESAM/nas10c/scratch/dvibert/tmp/it/2677c97c_b4f9b12_17190ac&lt;br/&gt;
&amp;lt;/pre&amp;gt;&lt;/p&gt;

&lt;p&gt;pour obtenir les rapports sur tous les tests: @amzdiffit . /net/CESAM/amazed/it/develop/latest_full full@&lt;br/&gt;
(&#231;a ne relance pas les tests, mais produit juste les rapport et r&#233;sum&#233;s, qui ne sont pas produits lorsque qu&apos;on lance les tests full...)&lt;/p&gt;

&lt;p&gt;il y a quelques tests full qui ont des diff&#233;rences (en plus des 2 roman):&lt;/p&gt;

&lt;p&gt;sp8_lm_linemeas_lbfgsb_velocityfit_false,&lt;br/&gt;
sp8_lm_linemeas_lbfgsb_lbdaoffsetfit_false,&lt;br/&gt;
se8_lm_secondpass_secondpasslcfittingmethod_svdlc,&lt;br/&gt;
se8_lm_secondpass_secondpasslcfittingmethod_svdlcp2&lt;/p&gt;

&lt;p&gt;&#224; v&#233;rifier si ces tests ont des diff&#233;rences &#224; cause de cette issue o&#249; probablement &#224; cause d&apos;un autre merge depuis le dernier run des IT full  ??? &lt;/p&gt;

&lt;p&gt;Sinon par rapport aux commentaires gitlab, &#231;a n&apos;apparait pas car les tests @lm_fittingmethod_random@ et @lm_firstpass_fittingmethod_random@ sont absents de la matrice de test.&lt;br/&gt;
il y a un &#233;cart de 4 tests entre la matrice linemodel est les tests dans linemodel_variations. Il manque les 2 random, et il reste les deux fittingmethod_lmfit qui aurait du dispara&#238;tre lorsque on a supprim&#233; lmfit... =&amp;gt; &#224; supprimer (dans ce ticket ?)&lt;/p&gt;</comment>
                            <comment id="36139" author="r2j.migrate" created="Mon, 27 Nov 2023 18:21:08 +0000"  >&lt;p&gt;Comment by Didier Vibert on 2023-11-17 12:37:55:&lt;br/&gt;
ah je comprends le pb: cette issue est bas&#233;e sur develop dont le dernier merge (changement de version lbfgspp #8436) produit des diff sur les IT full, mais que Pierre-Yves n&apos;a pas pu produire... &lt;/p&gt;
</comment>
                            <comment id="36140" author="r2j.migrate" created="Mon, 27 Nov 2023 18:21:19 +0000"  >&lt;p&gt;Comment by Fanny Dufresne on 2023-11-17 12:50:40:&lt;br/&gt;
Ah &#231;a me rassure un petit peu !&lt;/p&gt;</comment>
                            <comment id="36141" author="r2j.migrate" created="Mon, 27 Nov 2023 18:21:33 +0000"  >&lt;p&gt;Comment by Fanny Dufresne on 2023-11-17 12:51:05:&lt;br/&gt;
Du coup je laisse la suite entre vos mains ?&lt;/p&gt;</comment>
                            <comment id="36142" author="r2j.migrate" created="Mon, 27 Nov 2023 18:21:44 +0000"  >&lt;p&gt;Comment by Didier Vibert on 2023-11-17 13:23:45:&lt;br/&gt;
Fanny Dufresne wrote in #note-6:&lt;br/&gt;
&amp;gt; Du coup je laisse la suite entre vos mains ?&lt;/p&gt;

&lt;p&gt;oui, on verra avec @pychabau comment il veut faire&lt;/p&gt;</comment>
                            <comment id="36143" author="r2j.migrate" created="Mon, 27 Nov 2023 18:21:56 +0000"  >&lt;p&gt;Comment by Didier Vibert on 2023-11-17 14:44:47:&lt;br/&gt;
Fanny Dufresne wrote in #note-6:&lt;br/&gt;
&amp;gt; Du coup je laisse la suite entre vos mains ?&lt;/p&gt;

&lt;p&gt;j&apos;ai pouss&#233; sur dataset-parameters l&apos;ajout des IT random dans la matrice linemodel et supprim&#233; les tests lmfit.&lt;/p&gt;</comment>
                            <comment id="36144" author="r2j.migrate" created="Mon, 27 Nov 2023 18:22:10 +0000"  >&lt;p&gt;Comment by Didier Vibert on 2023-11-21 15:55:39:&lt;br/&gt;
Didier Vibert wrote in #note-3:&lt;/p&gt;

&lt;p&gt;&amp;gt; il y a quelques tests full qui ont des diff&#233;rences (en plus des 2 roman):&lt;br/&gt;
&amp;gt; &lt;br/&gt;
&amp;gt; sp8_lm_linemeas_lbfgsb_velocityfit_false,&lt;br/&gt;
&amp;gt; sp8_lm_linemeas_lbfgsb_lbdaoffsetfit_false,&lt;/p&gt;

&lt;p&gt;=&amp;gt; ok ceux l&#224; sont des diffs de l&apos;issue #8436 &lt;/p&gt;

&lt;p&gt;&amp;gt; se8_lm_secondpass_secondpasslcfittingmethod_svdlc,&lt;br/&gt;
&amp;gt; se8_lm_secondpass_secondpasslcfittingmethod_svdlcp2&lt;/p&gt;

&lt;p&gt;Ces 2 diffs qu&apos;on retrouve dans la branche d&apos;Ali (ie merge de cette issue sur develop avant #8436) sont bien d&#251; &#224; cette issue. &lt;/p&gt;

&lt;p&gt;cette issue modifie le param&#232;tre suivant:&lt;br/&gt;
&amp;lt;pre&amp;gt;&lt;br/&gt;
  &quot;galaxy&quot;: {&lt;br/&gt;
    &quot;LineModelSolve&quot;: {&lt;br/&gt;
      &quot;linemodel&quot;: {&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;&quot;secondpass&quot;: 
{
-          &quot;secondpasslcfittingmethod&quot;: &quot;svdlc&quot;
-        }
&lt;p&gt;+        &quot;secondpasslcfittingmethod&quot;: &quot;svdlc&quot;&lt;br/&gt;
      }&lt;br/&gt;
    }&lt;br/&gt;
  }&lt;br/&gt;
&amp;lt;/pre&amp;gt;&lt;/p&gt;&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;si on regarde le fichier de param g&#233;n&#233;r&#233; avant cette modif:&lt;br/&gt;
&amp;lt;pre&amp;gt;&lt;br/&gt;
                &quot;secondpass&quot;: &lt;/p&gt;
{
                    &quot;halfwindowsize&quot;: 0.003,
                    &quot;continuumfit&quot;: &quot;refitfirstpass&quot;,
                    &quot;secondpasslcfittingmethod&quot;: &quot;svdlc&quot;
                }
&lt;p&gt;,&lt;br/&gt;
                &quot;secondpasslcfittingmethod&quot;: -1,&lt;br/&gt;
&amp;lt;/pre&amp;gt;&lt;/p&gt;

&lt;p&gt;=&amp;gt; donc le param&#232;tre &#233;tait list&#233; &#224; 2 niveaux diff&#233;rents, et c&apos;est la valeur &quot;-1&quot; (aurait d&#251; &#234;tre une string...) provenant  du parameters_base.json qui &#233;tait prise en compte&lt;br/&gt;
=&amp;gt; le fitter svdlc n&apos;a jamais &#233;t&#233; test&#233; !  et idem pour svdlcp2&lt;/p&gt;

&lt;p&gt;Le diff de @fdufresne est bien correct et active maintenant cette option. Tant mieux le code ne crashe pas. Je vais analyser les diff&#233;rences des sorties pour voir si elle me semble refl&#233;ter le fonctionnement attendu...&lt;/p&gt;

&lt;p&gt;On en profite pour modifier le parameters_base pour mettre une string ? et du coup autre chose que &quot;-1&quot; (il faut n&apos;importe quoi diff&#233;rent de &quot;svdlc&quot; ou &quot;svdlcp2&quot; ). Peut &#234;tre &quot;no&quot; ? &lt;br/&gt;
Ou alors @fdufresne tu le fait &#224; l&apos;occasion de ton refacto du g&#233;n&#233;rateur de param ? &lt;/p&gt;</comment>
                            <comment id="36145" author="r2j.migrate" created="Mon, 27 Nov 2023 18:22:21 +0000"  >&lt;p&gt;Comment by Didier Vibert on 2023-11-22 09:02:21:&lt;/p&gt;

&lt;p&gt;Les diff&#233;rences de @se8_lm_secondpass_secondpasslcfittingmethod_svdlc@ sont ok.&lt;br/&gt;
En revanche, la sortie de   @se8_lm_secondpass_secondpasslcfittingmethod_svdlcp2@ est identique &#224; @se8_lm_secondpass_secondpasslcfittingmethod_svdlc@, or elle ne devrait pas...&lt;/p&gt;

&lt;p&gt;Par ailleurs, @fdufresne &lt;/p&gt;

&lt;p&gt;m&apos;a fait remarquer que la variation @extremacountB@ n&apos;&#233;tait pas activ&#233; &#224; cause d&apos;une mauvaise orthographe dans le parameters.json, cette issue corrige ce point, mais les sorties sont identiques &#224; se8_main, or elle ne devrait pas non plus...&lt;/p&gt;

&lt;p&gt;Ces 2 probl&#232;mes sont &#224; r&#233;soudre dans une issue d&#233;di&#233;e. (cf #8495 &amp;amp; #8496)&lt;/p&gt;

&lt;p&gt;je passe celle-ci en feedback.&lt;/p&gt;</comment>
                            <comment id="36146" author="r2j.migrate" created="Mon, 27 Nov 2023 18:22:45 +0000"  >&lt;p&gt;Comment by Pierre-yves Chabaud on 2023-11-24 14:41:15:&lt;br/&gt;
Merged into @develop@ (@3c15c613@)&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|zzt0en:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    </customfields>
    </item>
</channel>
</rss>