https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/REDMINE1D-356 1D Redmine <p><em><font color="#505f79"> Created on 2023-11-13 12:10:58 by Didier Vibert. % Done: 0</font></em></p> <p>with </p> <p>&lt;pre&gt;<br/> "LSF": </p> { "LSFType": "GaussianVariableWidth", "GaussianVariablewidthFileName": "LSF/roman_grism_lsf.fits" } <p>,<br/> &lt;/pre&gt; </p> <p>we get the warning "Unused parameter LSF GaussianVariablewidthFileName"</p> REDMINE1D-356

[RM-8476] [parameters checker] wrong warning: Unused parameter LSF GaussianVariablewidthFileName

Task Normal Open Unresolved Redmine-Jira Migtation Redmine-Jira Migtation Mon, 13 Nov 2023 18:15:39 +0000 Tue, 21 Nov 2023 18:19:11 +0000 0 1 <p>Comment by Didier Vibert on 2023-11-13 12:28:29:<br/> en fait sur le même run (IT roman), j'obtiens d'autres warning "unfair":</p> <h3><a name="continuumRemoval"></a>continuumRemoval</h3> <p>Warning: Unused parameter continuumRemoval medianKernelWidth<br/> Warning: Unused parameter continuumRemoval medianEvenReflection</p> <p>alors que continuum.component = "tplfitauto" =&gt; il peut basculer en fromspectrum </p> <h3><a name="reliability"></a>reliability</h3> <p>Warning: Unused parameter object galaxy reliability_enable <br/> dans le fichier de param il y a "enable_reliability": false, qui est requis, et en revanche avec false la propriété "reliability_model" est inutile (mais pas de warning)</p> <h3><a name="continuumreestimation"></a>continuumreestimation</h3> <p>Warning: Unused parameter object galaxy LineModelSolve continuumreestimation</p> <p>continuumreestimation est requis pour linemodelSolve (utilisé systématiquement)</p> <p>désolé si ces contraintes ont mal été spécifiées initialement, là je regarde ce que fait le code C++ pour conclure.</p> <p>Comment by Didier Vibert on 2023-11-21 08:33:13:<br/> je viens de regarder les logs des derniers IT full, donc je note dans cette issue, les warnings du checker qui me semble soit manquant, soit injustifiés...<br/> <b>WIP</b> j'éditerai ce commentaire pour finir avec les autres IT</p> <ul> <li>se8:</li> </ul> <ul> <li>continuumRemoval: no warning (only unused warning for continuumRemoval.medianKernelWidth &amp; continuumRemoval.medianEvenReflection), but whole section unused</li> </ul> <ul> <li>galaxy reliability_enabled: unused warning, but required (idem roman ci-dessus, required for all objects type galaxy/star/qso/...)</li> </ul> <ul> <li>LinemeasSolve: no warning, but unused.</li> </ul> <ul> <li>LineModelSolve.continuumreestimation: unused warning, but required (idem roman ci-dessus)</li> </ul> <ul> <li>LineModelSolve.useloglambdasampling: no warning, but unused (usefull only if continuum.component is tplfit* and continuumfit.fftprocessing true)</li> </ul> <ul> <li>se8_fromspectrum:</li> </ul> <ul> <li>continuumRemoval.medianKernelWidth &amp; medianEvenReflection: unused warning, but required (when Templatefitting, tplcombination &amp; LinemodelSolve with continuum.component=tplfitauto or fromspectrum)</li> </ul> <ul> <li>se8_templatefitting_fft:</li> </ul> <ul> <li>LSF: no warning (for whole section, only sourcesize): whole section unused (LSF section required only for LinemodelSolve)</li> </ul> <ul> <li>se8_variable_lsf:</li> </ul> <ul> <li>LSF.GaussianVariablewidthFileName: unused warning, but required</li> </ul> Development Rank 0|zzt0dz: