<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 15:31:45 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[REDMINE1D-343] [RM-8435] [parameters checker] add a dependance for asym Lya parameters</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/REDMINE1D-343</link>
                <project id="11002" key="REDMINE1D">1D Redmine </project>
                    <description>&lt;p&gt;&lt;em&gt;&lt;font color=&quot;#505f79&quot;&gt; Created on 2023-10-23 14:56:03 by Didier Vibert. % Done: 50&lt;/font&gt;&lt;/em&gt;&lt;/p&gt;


&lt;p&gt;all the parameters from @LineModelSolve.linemodel.lyafit@ section are necessary only if @LineModelSolve.linemodel.igmfit@ is False (and unused if True)&lt;/p&gt;

&lt;p&gt;same for parameters @LineModelSolve.linemodel.lyaforcefit@ and @LineModelSolve.linemodel.lyaforcedisablefit@ &lt;/p&gt;

&lt;p&gt;note: the section lyafit is read by the instanciation of any fitter (see CAbstractfitter constructor code). We must add a test on the igmfit param to read or not this section (and set the corresponding members to NAN if we don&apos;t read).&lt;/p&gt;

&lt;p&gt;BTW, in the @CAbstractFitter()@ constructor, these parameters should also be read if the method is @&quot;LineMeasSolve&quot;@. This is currently missing, and the linemeas solver is thus currently running through the Lya  asymmetric profile fitting using the hardcoded default values for the parameters ranges and steps...&lt;br/&gt;
Note that the default parameter currently used for linemeas is igmfit false (for all parameters, notably the one delivered to PFS)&lt;/p&gt;

&lt;p&gt;Thus we need to add the lyafit section in @LineMeasSolve@ with same dependance on igmfit. &lt;/p&gt;</description>
                <environment></environment>
        <key id="24083">REDMINE1D-343</key>
            <summary>[RM-8435] [parameters checker] add a dependance for asym Lya parameters</summary>
                <type id="3" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10518&amp;avatarType=issuetype">Task</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="3" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/inprogress.png" description="This issue is being actively worked on at the moment by the assignee.">In Progress</status>
                    <statusCategory id="4" key="indeterminate" colorName="yellow"/>
                                    <resolution id="-1">Unresolved</resolution>
                                        <assignee username="r2j.migrate">Redmine-Jira Migtation</assignee>
                                    <reporter username="r2j.migrate">Redmine-Jira Migtation</reporter>
                        <labels>
                    </labels>
                <created>Mon, 23 Oct 2023 18:15:44 +0000</created>
                <updated>Mon, 5 Feb 2024 18:20:59 +0000</updated>
                                                                                <due></due>
                            <votes>0</votes>
                                    <watches>1</watches>
                                                                <comments>
                            <comment id="36997" author="r2j.migrate" created="Mon, 5 Feb 2024 18:20:27 +0000"  >&lt;p&gt;Comment by Fanny Dufresne on 2024-02-01 16:18:14:&lt;br/&gt;
@dvibert what do you mean by &quot;same for parameters LineModelSolve.linemodel.lyaforcefit and LineModelSolve.linemodel.lyaforcedisablefit&quot; ?&lt;/p&gt;

&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;lyaforcefit and lyaforcedisable fit are necessary only if igm is false ?&lt;/li&gt;
	&lt;li&gt;lyaforcefit and lyaforcedisable fit are to be added in lineMeasSolve section ?&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="36998" author="r2j.migrate" created="Mon, 5 Feb 2024 18:20:32 +0000"  >&lt;p&gt;Comment by Didier Vibert on 2024-02-01 17:46:34:&lt;br/&gt;
Fanny Dufresne wrote in #note-3:&lt;br/&gt;
&amp;gt; @dvibert what do you mean by &quot;same for parameters LineModelSolve.linemodel.lyaforcefit and LineModelSolve.linemodel.lyaforcedisablefit&quot; ?&lt;br/&gt;
&amp;gt; &lt;br/&gt;
&amp;gt; - lyaforcefit and lyaforcedisable fit are necessary only if igm is false ? &lt;br/&gt;
&amp;gt; - lyaforcefit and lyaforcedisable fit are to be added in lineMeasSolve section ?&lt;/p&gt;

&lt;p&gt;yes both !&lt;/p&gt;</comment>
                            <comment id="36999" author="r2j.migrate" created="Mon, 5 Feb 2024 18:20:37 +0000"  >&lt;p&gt;Comment by Didier Vibert on 2024-02-01 17:58:55:&lt;br/&gt;
peut-&#234;tre impl&#233;menter #7688-12 dans la foul&#233;e ?&lt;/p&gt;</comment>
                            <comment id="37000" author="r2j.migrate" created="Mon, 5 Feb 2024 18:20:47 +0000"  >&lt;p&gt;Comment by Fanny Dufresne on 2024-02-02 09:50:00:&lt;br/&gt;
En regardant de plus pr&#232;s lyaForceFit et lyaForceDisableFit j&apos;ai l&apos;impression que : (avec =&amp;gt; signifie implique)&lt;/p&gt;
&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;lyaForceDisableFit &#224; true =&amp;gt; lyaForceFit et lyaFit section inutiles&lt;/li&gt;
	&lt;li&gt;lyaForceFit &#224; false =&amp;gt; lyaFit section inutile&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;La section lyaFit est finalement utile uniquement si lyaForceDisableFit &#224; false et lyaForceFit &#224; true ?&lt;/p&gt;</comment>
                            <comment id="37001" author="r2j.migrate" created="Mon, 5 Feb 2024 18:20:53 +0000"  >&lt;p&gt;Comment by Didier Vibert on 2024-02-02 13:44:15:&lt;br/&gt;
Fanny Dufresne wrote in #note-7:&lt;br/&gt;
&amp;gt; En regardant de plus pr&#232;s lyaForceFit et lyaForceDisableFit j&apos;ai l&apos;impression que : (avec =&amp;gt; signifie implique)&lt;br/&gt;
&amp;gt; - lyaForceDisableFit &#224; true =&amp;gt; lyaForceFit et lyaFit section inutiles&lt;br/&gt;
&amp;gt; - lyaForceFit &#224; false =&amp;gt; lyaFit section inutile&lt;br/&gt;
&amp;gt; &lt;br/&gt;
&amp;gt; La section lyaFit est finalement utile uniquement si lyaForceDisableFit &#224; false et lyaForceFit &#224; true ?&lt;/p&gt;

&lt;p&gt;cf &lt;a href=&quot;#Renaming]&quot;&gt;[AmazedlibParamRefactor_#Renaming]&lt;/a&gt;&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|zzt02n:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                    </customfields>
    </item>
</channel>
</rss>