[REDMINE1D-327] [RM-8382] [parameters checker] wrong check for velocitifit in linemeasSolve

Mon, 6 Nov 2023 18:21:54 +0000

Created on 2023-10-04 16:26:25 by Didier Vibert. % Done: 100

MR pylibamazed: https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/558
MR dataset-parameters: https://gitlab.lam.fr/amazed/dataset-parameters/-/merge_requests/65

when linemeasSolve and fittingmethod is "lbfgs" the velocityfit parameter is required.
and the checker is issuing a warning:

<pre>
Warning: Unused parameter object qso LineMeasSolve velocityfit
</pre>

the check is wrong because @"lbfgsb"@ is used for the ftting method instead of @"lbfgs"@ :

<pre><code class="python">
def _check_linemeassolve_fittingmethod_lbfgsb_velocityfit(self, object_type: str):
self._check_dependant_parameter_presence(
self.accessor.get_lineMeasSolve_fittingmethod(object_type) == "lbfgsb",
self.accessor.get_lineMeasSolve_velocityfit(object_type) is not None,
error_message=f"LineMeasSolve velocityfit for object

{object_type}",
warning_message=f"object {object_type}

LineMeasSolve velocityfit"
)
</code></pre>

PFS-JIRA

[REDMINE1D-327] [RM-8382] [parameters checker] wrong check for velocitifit in linemeasSolve