[REDMINE1D-314] [RM-8310] [linemodel] wrong output of some line ratio parameters

Thu, 28 Sep 2023 18:20:10 +0000

Created on 2023-09-20 11:20:46 by Didier Vibert. % Done: 100

after the end of the loop on line-ratio, the method @CTplratioManager::finish@ should refresh the elements with the fitted values coming from the best line ratio.

-the amplitude is wrongly refreshed because all the nominal amplitudes were not refreshed...
This has an impact on the computed model, and on the amplitude and flux of individual lines (including Ha complex and OII doublet). But the global amplitude and line ratio name are ok (since the call to @TLineModelResult::updateTplRatioFromModel@ at the end of @COperatorLineModel::buildExtremaResults@). The pdf and chisquare are ok too, with the redshift solution.-
the Lya asym parameters are not refreshed if the profile is ASYM (instead of ASYMFIT) because @CLine::SetAsymParams@ does nothing in ASYM case

maybe fixed by using LoadModelSolution

other bugs found:

"linemodel.cpp L1035":https://gitlab.lam.fr/CPF/cpf-redshift/-/blob/release-0.44/RedshiftLibrary/src/lib/operator/linemodel.cpp?ref_type=heads#L1035 photvalues are overwritten by empty values
in @TLineModelResult::updateTplRatioFromModel@ the line ratio abs amplitude is not saved

PFS-JIRA

[REDMINE1D-314] [RM-8310] [linemodel] wrong output of some line ratio parameters