https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/REDMINE1D-16 1D Redmine <p><em><font color="#505f79"> Created on 2021-04-16 16:37:15 by Didier Vibert. % Done: 100</font></em></p> <p>amplitude of absorption lines are unitless coefficient in <span class="error">&#91;0,1&#93;</span> and the effective spectral profile is </p> <p>s(lamda) = C(lambda)*(1-a)*LineProfile(lambda) where C(lambda) is the continuum, a is the fitted absorption amplitude and LineProfile is a normalized profile with maximum at 1.</p> <p>Thus the extinction of the continuum is operating on the absorptions lines, and it should not be applied a second time on the amplitude a. The current code for template ratio currently multiply the amplitude by the extinction low. It should not. </p> REDMINE1D-16

[RM-6459] template ratio ism extinction should not be applied to amplitude of absorption lines...

Task Normal Review Complete Unresolved Redmine-Jira Migtation Redmine-Jira Migtation Fri, 4 Jun 2021 01:19:35 +0000 Fri, 9 Feb 2024 18:34:44 +0000 0 1 <p>Comment by Didier Vibert on 2024-01-12 16:54:48:<br/> I let it in planif, I anticipate not too much conflict with #6028</p> <p>Comment by Didier Vibert on 2024-01-16 16:09:33:<br/> dans un premier temps, on se contente de modifier @CLineCatalogsTplRatio::InitLineCorrespondingAmplitudes@ pour que les amplitudes de l'élement en absorption ne soient pas modifiée par l'ism.</p> <p>dans un deuxième temps, on peut effectuer un refacto (un peu plus complexe) pour éviter de refitter l'élement en abs pour les ratios identiques correspondant à un index ism qui change. </p> <p>Comment by Gaelle Daste on 2024-01-26 12:25:06:<br/> Voici les ITs full comparés avec develop :<br/> /net/CESAM/amazed/gdaste/tests/fix_issue_6459</p> <p>Ca concerne le point "dans un premier temps" de ta note</p> <p>MR : <a href="https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/578" class="external-link" rel="nofollow">https://gitlab.lam.fr/CPF/cpf-redshift/-/merge_requests/578</a></p> <p>Comment by Didier Vibert on 2024-02-01 14:13:37:<br/> @gdaste stp tu peux créer un ticket pour traiter le refacto proposé dans un "deuxième temps" #note-15 si on ne le traite pas ici. merci</p> <p>Comment by Didier Vibert on 2024-02-01 15:25:36:<br/> ok pour le code. Dis-moi dès que tu as les IT que je regarde avant de passer en feedback</p> <p>Comment by Gaelle Daste on 2024-02-02 10:29:01:<br/> ITs full après la dernière modif : /net/CESAM/amazed/gdaste/tests/fix_issue_6459</p> <p>Comment by Didier Vibert on 2024-02-05 15:04:23:<br/> Gaelle Daste wrote in #note-22:<br/> &gt; ITs full après la dernière modif : /net/CESAM/amazed/gdaste/tests/fix_issue_6459</p> <p>ok c'est bon.</p> <p>Comment by Pierre-yves Chabaud on 2024-02-09 14:06:52:<br/> Merged into @develop@ (@5ad7c2d0@)</p> Development Rank 0|zzs7ag: