https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/REDMINE1D-106 1D Redmine <p><em><font color="#505f79"> Created on 2023-04-06 09:14:09 by Didier Vibert. % Done: 50</font></em></p> <p>when the continuum is refitted, eventually partially in the case @ LineModelSolve.linemodel.secondpass.continuumfit = "refitfirstpass"@, <br/> the amplitude can be found compatible with zero (resp. negative) in the considered second pass redshift window, whereas it was found in the 1st pass full z range, that at some other redshift the continuum amplitude is significantly not null (resp. positive). Currently, the code switch to "nocontinuum" (resp. "fromspectrum") globally , for all 2nd pass candidates.</p> <p>We should either make the switch for only the candidate where it appears, or not switch at all, since in first pass the continuum was found significant.<br/> I vote for 2nd option. Moreover the whole pdf, outside the 2nd pass windows, was computed using continuum template fitting, thus we should keep this info and all the associated parameters (name of template, amplitude, ism, igm)</p> REDMINE1D-106

[RM-8005] [linemodel] do not switch to nocontinuum or fromspectrum in second pass continuum refit

Task Normal In Progress Unresolved Redmine-Jira Migtation Redmine-Jira Migtation Tue, 13 Jun 2023 05:00:55 +0000 Wed, 7 Feb 2024 18:23:25 +0000 0 2 <p>Comment by Vincent Le Brun on 2023-04-06 10:54:17:<br/> OK if the 2nd pass amplitude is found to be 0, but if it is negative, and we do not switch, an error will be raised ?</p> <p>Comment by Didier Vibert on 2023-04-06 12:27:02:<br/> Vincent Le Brun wrote in #note-2:<br/> &gt; OK if the 2nd pass amplitude is found to be 0, but if it is negative, and we do not switch, an error will be raised ?</p> <p>The option 2 is to not raise any error which abort the object (QSO/Galaxy) fittting, but issue a warning and let the code continue with a null continuum (when it is negative, above the negative threshold it is considered null). Keep in mind that in the first pass, around the same redshifts (on a coarser grid) it was not considered negative, so we are in the case were it is at the limit of the threshold, It will probably not change anything at the end. And to introduce a "fromspectrum" continuum switch that is not global needs some refactoring. </p> <p>Comment by Didier Vibert on 2023-04-06 12:39:46:<br/> Another comment: in first pass, the switch to "fromspectrum" arises if <b>at all z in the full z range</b> the continuum is fitted with a negative amplitude (below the threshold). What happens currently in 2nd pass is to switch if it is fitted negative on all the z-range of one 2nd pass window. Since the 2nd pass window contains some of the z of the first pass grid, the only thing I see that can change the behavior is the use of fft in first-pass only (it is deactivated in 2nd pass because the z-range is too small to have a cpu tiime benefit).</p> <p>Comment by Vincent Le Brun on 2023-04-06 13:29:32:<br/> OK let's go like this</p> <p>Comment by Gaelle Daste on 2024-01-29 12:42:40:<br/> J'ai pas trouvé dans les ITs (même full) de cas où on avait ce switch. Pour voir et valider le avant/après si quelqu'un a une idée je suis preneuse</p> <p>Comment by Gaelle Daste on 2024-02-06 15:00:09:<br/> #8580 </p> Development Rank 0|zzsxgv: