https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-98 DRP 2-D Pipeline <p><a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-90" title="Create Calib Task to create and write FiberTraces" class="issue-link" data-issue-key="PIPE2D-90"><del>PIPE2D-90</del></a> was merged into master without confirmation that the code is correct. Please add a test case that a FiberTraceSet reconstructed from a pfsFiberTrace file is identical to the original FiberTraceSet that was used to write the pfsFiberTrace file.</p> PIPE2D-98

Add test to confirm that a FiberTraceSet reconstructed from pfsFiberTrace is identical to the original one

Story Major Done Done aritter aritter Tue, 11 Oct 2016 06:15:02 +0000 Tue, 27 Dec 2016 22:10:07 +0000 Tue, 27 Dec 2016 22:10:07 +0000 0 3 <p>Currently, the round trip ends up with something which is nearly, but not quite, identical. This may be due to lack of precision due to only persisting floats. Still under investigation.</p> <p>I have confirmed that the lack of precision in the trace-function coefficients due to only persisting floats is responsible for the difference between the stored FiberTraces and the reconstructed ones. This means that we will have to change the datamodel to persist the trace-function coefficients as double values.<br/> When I set the trace coefficients in the reconstructed FiberTrace manually to the ones from the original FiberTrace, recalculate the xCenters, and re-create the FiberTrace using the new xCenters, both FiberTraces are identical.</p> <p>Filed ticket <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-13" title="Change pfsFiberTrace description to persist trace-function coefficients as double" class="issue-link" data-issue-key="DAMD-13"><del>DAMD-13</del></a> to change the description of pfsFiberTrace to use doubles instead of floats for the trace-function coefficients</p> <p>I can confirm now that the FiberTraces read in from disk is now identical to the FiberTraces which were persisted to disk.<br/> Previously the FiberTraceFunction coefficients were internally saved as doubles. When persisting the coefficients as floats and reading them back in, the difference in precision caused a 1 pixel offset in 1 row in 1 FiberTrace out of 12. Changing the internal coefficients to float removed the observed pixel offset.</p> <p>I made review comments on the GitHub pull requests that I hope will simplify the code.</p> <p>Please check that the test you've added used to fail when you were using <tt>double</tt> in drp_stella. In particular, I'm concerned that the imprecise comparisons (<tt>assertAlmostEqual</tt>) might hide problems.</p> <p>Merged into master</p> Blocks DAMD-13 Relates DAMD-13 PIPE2D-90 Development Epic Link PIPE2D-47 Rank 0|ii00nq:r Reviewers price Sprint 2014-16 Story Points 1.0