https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-966 DRP 2-D Pipeline <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> ====================================================================== FAIL: testResiduals (__main__.ArcTestCase_brn_39) (arm=<span class="code-quote">'b'</span>, fiberId=2) Test that wavelength fit residuals are reasonable ---------------------------------------------------------------------- Traceback (most recent call last): File <span class="code-quote">"/scratch/pprice/jenkins/weekly/2022-01-02/build/stack/miniconda3-4.5.12-1172c30/Linux64/pfs_pipe2d/w.2022.01/python/pfs/pipe2d/weekly/test_weekly.py"</span>, line 139, in testResiduals self.assertFloatsAlmostEqual(robustRms, 0.0, atol=atol) File <span class="code-quote">"/scratch/pprice/jenkins/weekly/2022-01-02/build/stack/miniconda3-4.5.12-1172c30/Linux64/utils/18.1.0/python/lsst/utils/tests.py"</span>, line 735, in assertFloatsAlmostEqual testCase.assertFalse(failed, msg=<span class="code-quote">"\n"</span>.join(errMsg)) AssertionError: True is not <span class="code-keyword">false</span> : 0.079973473945946 != 0.0; diff=0.079973473945946/0.079973473945946=1.0 with rtol=2.220446049250313e-16, atol=0.05 </pre> </div></div> PIPE2D-966

Investigate failed weekly 2022-01-02

Story Normal Done Done price price Tue, 4 Jan 2022 18:31:47 +0000 Mon, 10 Jan 2022 18:05:40 +0000 Mon, 10 Jan 2022 18:05:40 +0000 0 2 <p>Discovered that <tt>applyExclusionZone</tt> wasn't working following the changes to the backend. Fixed that, and added some tests.</p> <p>In general changes look fine, but please see comment in pull request regarding the scenario where two lines with <em>exactly</em> the same wavelength (well, to numerical precision) are not marked as rejected.</p> <p>Not flagging lines with the same wavelength was the existing behaviour, so we agreed that changes to that can be made in another ticket.</p> <p>Merged.</p> Development Rank 0|zzssun: Reviewers hassan