PFS-JIRA

PFS-JIRA https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us

8.3.4

803005

13-09-2019

[PIPE2D-952] Spurious features appear in merged spectra https://pfspipe.ipmu.jp/jira/browse/PIPE2D-952 DRP 2-D Pipeline <p>For <tt>'visit': 69546, 'arm': 'r', 'spectrograph': 1</tt> there are features in the merged spectra that don't appear in the arm spectra. Please investigate and fix.</p> <p>This is using the <tt>CALIB-PFI-20211108</tt> calibs (copied to Hilo)</p> PIPE2D-952

Spurious features appear in merged spectra

Story Normal Done Done price rhl Sat, 20 Nov 2021 05:08:22 +0000 Mon, 20 Dec 2021 23:35:29 +0000 Mon, 20 Dec 2021 23:35:29 +0000 0 2 <p>Looks much better. What was the problem? Calibs?</p> <p>Between <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-948" title="reduceArc: restore the use of continuum as well as arc data" class="issue-link" data-issue-key="PIPE2D-948"><del>PIPE2D-948</del></a> (and new calibs <tt>CALIB-PFI-20211220</tt>) and <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-799" title="Correct for Jacobian when resampling" class="issue-link" data-issue-key="PIPE2D-799"><del>PIPE2D-799</del></a> and possibly <tt>isr.doApplyGains=True</tt>, this appears to have been resolved. I'll have a quick play to see if I can determine which one is responsible.</p> <p><span class="image-wrap" style=""><img src="https://pfspipe.ipmu.jp/jira/secure/attachment/15056/15056_pipe2d-952-fixed.png" style="border: 0px solid black" /></span></p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> (lsst-scipipe) pprice@tiger2-sumire:/scratch/pprice/pipe2d-952 $ reduceExposure.py /projects/HSC/PFS/Subaru --calib /projects/HSC/PFS/Subaru/CALIB-PFI-20211220 --rerun price/pipe2d-952 --id visit=69546 -c isr.doFlat=False isr.doApplyGains=True repair.doCosmicRay=False doAdjustDetectorMap=False -j 2 (lsst-scipipe) pprice@tiger2-sumire:/scratch/pprice/pipe2d-952 $ mergeArms.py /projects/HSC/PFS/Subaru --calib /projects/HSC/PFS/Subaru/CALIB-PFI-20211220 --rerun price/pipe2d-952 --id visit=69546 -c doSubtractSky1d=False >>> from lsst.daf.persistence <span class="code-keyword">import</span> Butler >>> butler = Butler(<span class="code-quote">"/projects/HSC/PFS/Subaru/rerun/price/pipe2d-952"</span>) >>> merged = butler.get(<span class="code-quote">"pfsMerged"</span>, visit=69546) >>> fig, axes = merged.plot(fiberId=[409, 501], show=False) >>> axes.set_xlim(680, 740) >>> axes.set_ylim(-300, 700) >>> axes.legend() >>> fig.show() </pre> </div></div> <p>Fixed by the reworked normalisation code in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-799" title="Correct for Jacobian when resampling" class="issue-link" data-issue-key="PIPE2D-799"><del>PIPE2D-799</del></a>.</p> Development Rank 0|zzs9um:a Sprint 2DDRP-2021 A12 Story Points 3.0