<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:00:13 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[PIPE2D-946] Sky subtraction doesn&apos;t take fibre sensitivity into account</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/PIPE2D-946</link>
                <project id="10002" key="PIPE2D">DRP 2-D Pipeline</project>
                    <description>&lt;p&gt;The 1-D sky subtraction code doesn&apos;t seem to normalise the spectra correctly. I took one of the September PFI visits (68879) and labelled all the fibres in the third to tenth percentile of flux as &lt;tt&gt;SKY&lt;/tt&gt;, then reduced the data. &#160;The raw data (pfsMerged.flux with no SKY fibres) are&#160; &lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;a id=&quot;14471_thumb&quot; href=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/14471/14471_68879-r1-skysub.png&quot; title=&quot;68879-r1-skysub.png&quot; file-preview-type=&quot;image&quot; file-preview-id=&quot;14471&quot; file-preview-title=&quot;68879-r1-skysub.png&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/thumbnail/14473/_thumb_14473.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/a&gt;&lt;/span&gt; &#160;and the sky models (pfsMerged.sky) are&#160; &lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/thumbnail/14472/_thumb_14472.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt; . &#160;The sky-subtracted spectra (also pfsMerged.flux) are&#160; &lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;a id=&quot;14471_thumb&quot; href=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/14471/14471_68879-r1-skysub.png&quot; title=&quot;68879-r1-skysub.png&quot; file-preview-type=&quot;image&quot; file-preview-id=&quot;14471&quot; file-preview-title=&quot;68879-r1-skysub.png&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/thumbnail/14471/_thumb_14471.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/a&gt;&lt;/span&gt; &#160;and the problem is clearly seen.&lt;/p&gt;</description>
                <environment></environment>
        <key id="18342">PIPE2D-946</key>
            <summary>Sky subtraction doesn&apos;t take fibre sensitivity into account</summary>
                <type id="10001" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10515&amp;avatarType=issuetype">Story</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="price">price</assignee>
                                    <reporter username="rhl">rhl</reporter>
                        <labels>
                    </labels>
                <created>Fri, 12 Nov 2021 00:58:00 +0000</created>
                <updated>Fri, 3 Dec 2021 12:42:26 +0000</updated>
                            <resolved>Tue, 30 Nov 2021 18:43:21 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>2</watches>
                                                                <comments>
                            <comment id="25055" author="rhl" created="Fri, 12 Nov 2021 01:01:08 +0000"  >&lt;p&gt;I suspect that this comes from modelling the sky in normalised units (not raw counts) so that the sky estimates from different fibres can be combined, but not correctly transforming these normalised units back to per-fibre counts.&lt;/p&gt;</comment>
                            <comment id="25091" author="price" created="Mon, 15 Nov 2021 22:27:47 +0000"  >&lt;p&gt;I retrieved the normalisation values from the &lt;tt&gt;fiberProfiles&lt;/tt&gt;, and found that the line intensity (bright, isolated line at 843.2491: 6-2 P1(3.5) close doublet) plotted against the normalisation has a large scatter. If the normalisation had been applied to the measured line intensities, this should be a horizontal line. If the normalisation had not been applied, this should be a sloped line. The normalisation comes from the flux in the extracted quartz flat, and it&apos;s strange that this should not be tightly correlated with the sky line flux. I wonder if this is related to engineering activities of some sort?&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/14476/14476_intensity_norm.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;/p&gt;</comment>
                            <comment id="25092" author="price" created="Tue, 16 Nov 2021 00:11:14 +0000"  >&lt;p&gt;Looking at the images (quartz.jpg and sky.jpg), the fibers appear to have different intensity patterns. Below is a horizontal cut at the position of a sky line for a quartz and sky. The variation seen here seems qualitatively consistent with what&apos;s seen in the plots. I conclude that problem is intrinsic to the data.&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/14480/14480_quartz-graph.jpg&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;br/&gt;
&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/14479/14479_sky-graph.jpg&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;/p&gt;</comment>
                            <comment id="25099" author="price" created="Tue, 16 Nov 2021 16:13:10 +0000"  >&lt;p&gt;I don&apos;t think any further work is possible without knowing exactly what the differences between the quartz (68345) and sky (68879) are.&lt;/p&gt;

&lt;p&gt;I made one commit in drp&amp;#95;stella, to select sky fibers when none are provided.&lt;/p&gt;</comment>
                            <comment id="25183" author="price" created="Mon, 29 Nov 2021 21:27:37 +0000"  >&lt;p&gt;The sky (68879) is much more like a quartz taken after (69006).&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/14497/14497_pipe2d-946.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;/p&gt;</comment>
                            <comment id="25185" author="rhl" created="Tue, 30 Nov 2021 18:43:22 +0000"  >&lt;p&gt;Paul&apos;s analysis looks right.&lt;/p&gt;

&lt;p&gt;We can merge the all-sky hack, but I think in general that it&apos;s better to write a modified `pfsConfig` file to a rerun that defines a set of sky fibres.  Because the sky fibre assignment isn&apos;t part of the design it doesn&apos;t modify the pfsConfigId so the book-keeping all works.&lt;/p&gt;</comment>
                            <comment id="25186" author="price" created="Tue, 30 Nov 2021 19:04:47 +0000"  >&lt;p&gt;Merged the all-sky hack, as it gives us options for future cases.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="14473" name="68879-r1-raw.png" size="353997" author="rhl" created="Fri, 12 Nov 2021 00:49:45 +0000"/>
                            <attachment id="14472" name="68879-r1-sky.png" size="232430" author="rhl" created="Fri, 12 Nov 2021 00:50:08 +0000"/>
                            <attachment id="14471" name="68879-r1-skysub.png" size="226965" author="rhl" created="Fri, 12 Nov 2021 00:50:17 +0000"/>
                            <attachment id="14476" name="intensity_norm.png" size="27172" author="price" created="Mon, 15 Nov 2021 22:19:24 +0000"/>
                            <attachment id="14475" name="intensity.png" size="29193" author="price" created="Mon, 15 Nov 2021 21:36:28 +0000"/>
                            <attachment id="14497" name="pipe2d-946.png" size="335974" author="price" created="Mon, 29 Nov 2021 21:28:51 +0000"/>
                            <attachment id="14480" name="quartz-graph.jpg" size="84296" author="price" created="Tue, 16 Nov 2021 00:08:09 +0000"/>
                            <attachment id="14477" name="quartz.png" size="35783" author="price" created="Tue, 16 Nov 2021 00:04:59 +0000"/>
                            <attachment id="14479" name="sky-graph.jpg" size="81339" author="price" created="Tue, 16 Nov 2021 00:08:09 +0000"/>
                            <attachment id="14478" name="sky.png" size="40062" author="price" created="Tue, 16 Nov 2021 00:05:00 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|zzs9ul:xy</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>rhl</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10005" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="125">2DDRP-2021 A11</customfieldvalue>
    <customfieldvalue id="126">2DDRP-2021 A12</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    </customfields>
    </item>
</channel>
</rss>