https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-937 DRP 2-D Pipeline <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> reports that with <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-933" title="Fix normalisation of extracted spectra" class="issue-link" data-issue-key="PIPE2D-933"><del>PIPE2D-933</del></a> (see the image attached there), the extraction is writing <tt>NaN</tt> values in the exposure.</p> PIPE2D-937

Extraction is producing NaNs in the calexp

Story Normal Done Done price price Mon, 8 Nov 2021 19:28:28 +0000 Wed, 10 Nov 2021 02:24:43 +0000 Wed, 10 Nov 2021 02:24:43 +0000 0 2 <p>Tracked this to the continuum subtraction context manager, where the continuum image has <tt>NaN</tt> values so subtracting and then adding leaves <tt>NaN</tt> values in the original image. The fiberTraces have <tt>NaN</tt> values because the fiberProfile normalisation has <tt>NaN</tt> values.</p> <p>Fixed this by masking out the <tt>NaN</tt> values in the fiberTraces and continuum-subtracted image, and changing the context manager to restore the original completely rather than adding the continuum back.</p> <p>No problems found in suggested changes. </p> <p>One comment, and better deferred to a separate ticket after the engineering run: can we have a check at the unit test and/or integration test or weekly test level that demonstrates that the extraction is performing as expected?</p> <p>Filed <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-940" title="Extend tests" class="issue-link" data-issue-key="PIPE2D-940">PIPE2D-940</a> to extend the tests.</p> <p>Merged.</p> Development Rank 0|zzs9ul:xk Reviewers hassan Sprint 2DDRP-2021 A11