https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-936 DRP 2-D Pipeline <p>With the bootstrapped PFI detectorMap from <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-933" title="Fix normalisation of extracted spectra" class="issue-link" data-issue-key="PIPE2D-933"><del>PIPE2D-933</del></a>, <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> reports that <tt>findFiberId</tt> produces obviously-wrong results:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> y = 2945 <span class="code-keyword">for</span> x in [97, 692, 711, 2602]: print(f<span class="code-quote">"({x},{y}) {detMap.findFiberId(geom.PointD(x, y))}"</span>) </pre> </div></div> <p>produces:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> (97, 2945) 315 (692, 2945) 315 (711, 2945) 315 (2602, 2945) 231 </pre> </div></div> PIPE2D-936

SplinedDetectorMap::findFiberId is broken

Story Normal Done Done price price Mon, 8 Nov 2021 19:27:10 +0000 Wed, 10 Nov 2021 20:41:23 +0000 Wed, 10 Nov 2021 20:41:23 +0000 0 1 <p>Note that this only occurs with the <tt>SplinedDetectorMap</tt> that we use for the simulator-derived and bootstrapped detectorMaps. Other subclasses of <tt>DetectorMap</tt> (in particular the <tt>DoubleDetectorMap</tt> we generally use, derived from fitting arc lines and sky lines) use a different implementation of <tt>findFiberId</tt>. So this bug should not be seen in the wild if we're using the right detectorMaps.</p> <p>Dumped the <tt>SplinedDetectorMap::findFiberId</tt> implementation, and moved the <tt>ModelBasedDetectorMap::findFiberId</tt> into the base class for all to use.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> pfs@52d67892cb5d:~/pfs/drp_stella (tickets/PIPE2D-936=) $ python -c <span class="code-quote">'from pfs.drp.stella <span class="code-keyword">import</span> DetectorMap; from lsst.geom <span class="code-keyword">import</span> Point2D; detMap = DetectorMap.readFits(<span class="code-quote">"pfsDetectorMap-068100-r1.fits"</span>); print(detMap.findFiberId(Point2D(97, 2945)), detMap.findFiberId(Point2D(711, 2945)), detMap.getXCenter(647, 2945), detMap.getXCenter(548, 2945))'</span> 647 548 97.01797764634567 711.3482153210797 </pre> </div></div> <p>Merged.</p> Development Rank 0|zzs9ul:xj Reviewers hassan Sprint 2DDRP-2021 A11