https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-926 DRP 2-D Pipeline <p>When running <tt>reduceArc.py</tt>, the results obtained with <tt>fitDetectorMap.doSlitOffsets=True</tt> are typically much worse than with <tt>False</tt>. I attribute this to lack of robustness in the slit offset measurement. The <tt>SplinedDetectorMap::measureSlitOffsets</tt> doesn't do any rejection of outliers. <tt>DistortionBasedDetectorMap::measureSlitOffsets</tt> uses <tt>SplinedDetectorMap::measureSlitOffsets</tt> but in the end the slit offsets don't change. Finally, consider moving the measurement of the slit offsets to after the distortion measurement rather than before.</p> PIPE2D-926

Make slit offset measurement more robust

Story Normal Done Done price price Tue, 26 Oct 2021 20:48:47 +0000 Thu, 18 Nov 2021 15:10:06 +0000 Thu, 18 Nov 2021 15:10:06 +0000 0 2 <p>I'm really happy with the results. Below is what I get on the PFI arcs: the 0.04 pixel residual error is reduced to 0.01.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> reduceArc.py /projects/HSC/PFS/Subaru --calib /projects/HSC/PFS/Subaru/CALIB-PFI-20211108 --rerun price/pipe2d-926 --id visit=68096..68100 arm=r -j 10 -c reduceExposure.isr.doFlat=False fitDetectorMap.doSlitOffsets=True [...] reduceArc.fitDetectorMap INFO: Final fit: chi2=213531.525274 dof=136524 xRMS=0.052833 yRMS=0.051992 (0.004489 nm) xSoften=0.043156 ySoften=0.042405 from 68292/69153 lines reduceArc.fitDetectorMap INFO: Fit quality from reserved lines: chi2=66920.399276 xRMS=0.059545 yRMS=0.057841 (0.004994 nm) xSoften=0.083305 ySoften=0.066542 from 7684 lines (10.0%) reduceArc.fitDetectorMap INFO: Softened fit: chi2=136464.653763 dof=136524 xRMS=0.054736 yRMS=0.053694 (0.004636 nm) xSoften=0.043148 ySoften=0.042385 from 7684 lines reduceArc.fitDetectorMap INFO: Softened fit quality from reserved lines: chi2=39015.828882 xRMS=0.059519 yRMS=0.057707 (0.004982 nm) xSoften=0.083298 ySoften=0.066536 from 7684 lines reduceArc.fitDetectorMap INFO: Slit offsets measurement: chi2=52070.972753 dof=115592 xRMS=0.029637 yRMS=0.028872 xSoften=0.008566 ySoften=0.008473 from 58388/68292 lines reduceArc.fitDetectorMap INFO: Unable to measure slit offsets <span class="code-keyword">for</span> 24 fiberIds: [1, 3, 45, 92, 114, 137, 184, 204, 229, 273, 280, 309, 314, 316, 336, 359, 370, 382, 426, 471, 515, 560, 607, 651] reduceArc.fitDetectorMap INFO: Final result: chi2=437360.934112 dof=135340 xRMS=0.017951 yRMS=0.018199 xSoften=0.011498 ySoften=0.011607 from 68292 lines </pre> </div></div> <p>No comments on the suggested changes in the pull request. Would be good to see what the residual error is for the <tt>b</tt> band also. This can be looked at later however.</p> <p>We'll worry about the blue-side stats after <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-948" title="reduceArc: restore the use of continuum as well as arc data" class="issue-link" data-issue-key="PIPE2D-948"><del>PIPE2D-948</del></a>.</p> <p>Merged.</p> Development Rank 0|zzs9ul:xu Reviewers hassan Sprint 2DDRP-2021 A11 Story Points 2.0