https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-916 DRP 2-D Pipeline <p>The weekly failed due to wavelength residuals being high:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> ====================================================================== FAIL: testResiduals (__main__.ArcTestCase_brn_39) (arm=<span class="code-quote">'r'</span>, fiberId=165) Test that wavelength fit residuals are reasonable ---------------------------------------------------------------------- Traceback (most recent call last): File <span class="code-quote">"/scratch/pprice/jenkins/weekly/2021-10-17/build/stack/miniconda3-4.5.12-1172c30/Linux64/pfs_pipe2d/w.2021.42/python/pfs/pipe2d/weekly/test_weekly.py"</span>, line 136, in testResiduals self.assertFloatsAlmostEqual(median, 0.0, atol=atol) File <span class="code-quote">"/scratch/pprice/jenkins/weekly/2021-10-17/build/stack/miniconda3-4.5.12-1172c30/Linux64/utils/18.1.0/python/lsst/utils/tests.py"</span>, line 735, in assertFloatsAlmostEqual testCase.assertFalse(failed, msg=<span class="code-quote">"\n"</span>.join(errMsg)) AssertionError: True is not <span class="code-keyword">false</span> : -0.0212058729346154 != 0.0; diff=0.0212058729346154/0.0212058729346154=1.0 with rtol=2.220446049250313e-16, atol=0.02 </pre> </div></div> <p>I also noticed that the sky model fit has a non-finite chi^2:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> + mergeArms.py /scratch/pprice/jenkins/weekly/2021-10-17/process --calib=/scratch/pprice/jenkins/weekly/2021-10-17/process/CALIB --rerun=weekly/pipeline/bmn/pipeline --doraise -j10 --id <span class="code-quote">'visit=50^51^52^55^56^58'</span> [...] mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=76238.614984 length=4172/4176 numSamples=120 numGood=494172 numBad=6583 numRejected=386 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=154280.445883 length=4172/4176 numSamples=120 numGood=494228 numBad=6239 numRejected=726 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=154219.982931 length=4172/4176 numSamples=120 numGood=494184 numBad=6317 numRejected=721 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4172/4176 numSamples=120 numGood=494141 numBad=6274 numRejected=740 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4172/4176 numSamples=120 numGood=494431 numBad=5957 numRejected=768 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4173/4176 numSamples=120 numGood=494298 numBad=6149 numRejected=754 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4095/4176 numSamples=120 numGood=477835 numBad=18264 numRejected=5624 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4105/4176 numSamples=120 numGood=459494 numBad=24426 numRejected=21165 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4104/4176 numSamples=120 numGood=421857 numBad=64460 numRejected=20467 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4096/4176 numSamples=120 numGood=459512 numBad=23583 numRejected=21346 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4104/4176 numSamples=120 numGood=374855 numBad=112364 numRejected=21396 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4104/4176 numSamples=120 numGood=425090 numBad=60247 numRejected=21474 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4149/4176 numSamples=120 numGood=487595 numBad=13488 numRejected=37 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4150/4176 numSamples=120 numGood=487177 numBad=12690 numRejected=1284 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4149/4176 numSamples=120 numGood=486650 numBad=13298 numRejected=1224 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4148/4176 numSamples=120 numGood=486955 numBad=13019 numRejected=1185 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4152/4176 numSamples=120 numGood=487169 numBad=12833 numRejected=1187 mergeArms.fitSkyModel INFO: Fit focal plane function: chi^2=nan length=4152/4176 numSamples=120 numGood=487049 numBad=12926 numRejected=1249 </pre> </div></div> PIPE2D-916

Debug 2021-10-17 weekly

Story Normal Done Done price price Tue, 19 Oct 2021 19:46:47 +0000 Fri, 5 Nov 2021 14:40:28 +0000 Thu, 4 Nov 2021 03:13:16 +0000 0 3 <p>I believe I've made the residual check much more robust.</p> <p>What changed that the check needed to be more robust? And are those NaNs new; if so, we need a ticket to investigate (actually, we probably need one anyway)</p> <p>That check has long been overly-sensitive. It's calculating the RMS of the residual from the wavelength solution. The problem is that it's using all lines, including low S/N lines, which artificially inflates the RMS. By restricting the calculation to high-S/N lines, the RMS calculation is much more robust.</p> <p>The {{NAN}}s are new (not present in the weekly of 2021-10-10). I'm not sure how that's possible, since I traced them back to the spectral extraction (bad variance though good flux). But they are not appearing now when I run the weekly again with the fixed code.</p> <p>Well, in general I think that making the test more robust is a good thing, but I worry about what changed to trigger the failures.</p> <p>What did we change that could have changed the wavelength residuals?</p> <p>All the code changes look reasonable. The questions <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> above would need to be addressed in a separate ticket.</p> <p>Merged.</p> Development Rank 0|zzs9ul:w Reviewers hassan Sprint 2DDRP-2021 A 10 2DDRP-2021 A11 Story Points 1.0