https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-913 DRP 2-D Pipeline <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=vlebrun" class="user-hover" rel="vlebrun">vlebrun</a> reports (<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE1D-53" title="[0.24.0] Mask values no properly used" class="issue-link" data-issue-key="PIPE1D-53"><del>PIPE1D-53</del></a>) that the noise level in pfsObjects is incorrect.</p> PIPE2D-913

pfsObject noise is incorrect

Story Normal Done Done price price Wed, 6 Oct 2021 14:01:00 +0000 Fri, 15 Oct 2021 17:57:49 +0000 Fri, 15 Oct 2021 17:57:49 +0000 0 3 <p>This was due to a subtle effect in <tt>PfsFiberArraySet.&#95;&#95;itruediv&#95;&#95;</tt>. In flux calibration, we divide the spectrum by the spectrum's normalisation. But in the process of that division, the normalisation is changed, which meant that the flux and the variance were not divided through by the same values.</p> <p>Changes makes sense. For changes in <tt>drp_stella</tt> <a href="https://github.com/Subaru-PFS/drp_stella/pull/225" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/drp_stella/pull/225</a> consider using a common set of functions to avoid code duplication.</p> <p>After some thought, I would like to keep the implementations for PfsFiberArray and PfsFiberArraySet distinct, because I think if we try to combine them we'll end up with a function that's more about the exceptions than the common behaviour. But I did take the opportunity to reduce code duplication by making the division implementations use the multiplication. Thanks for the suggestion!</p> <p>Merged.</p> Blocks PIPE1D-53 Development Rank 0|zzs9ul: Reviewers hassan Sprint 2DDRP-2021 A 10 Story Points 2.0