PFS-JIRA

PFS-JIRA https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us

8.3.4

803005

13-09-2019

[PIPE2D-897] pfsObject flux is not in nJy https://pfspipe.ipmu.jp/jira/browse/PIPE2D-897 DRP 2-D Pipeline <p><font color="#172b4d">Looking at the weekly results at IPMU with `w.2021.37`, `pfsObject.flux` does not seem to be in nJy. Please confirm this and fix if this is true.</font></p> PIPE2D-897

pfsObject flux is not in nJy

Task Normal Done Done price Kiyoto Yabe Mon, 13 Sep 2021 07:31:22 +0000 Fri, 24 Sep 2021 04:00:10 +0000 Fri, 24 Sep 2021 04:00:10 +0000 0 3 <p>Discovered a normalisation bug in flux calibration.</p> <p>Changes look OK to me. Did you look at the final pfsObject flux for an example file?</p> <p>Here's the log of my investigation:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> >>> from lsst.daf.persistence <span class="code-keyword">import</span> Butler >>> butler = Butler(<span class="code-quote">"/scratch/pprice/jenkins/weekly/2021-09-19/process/rerun/weekly/pipeline/brn/pipeline/"</span>) >>> pfsConfig = butler.get(<span class="code-quote">"pfsConfig"</span>, visit=47) >>> from pfs.datamodel <span class="code-keyword">import</span> TargetType >>> pfsConfig.select(targetType=TargetType.FLUXSTD).objId array([ 8, 13, 23, 53, 3, 26, 6, 52, 39, 54, 7, 33, 49, 41, 1, 37, 18, 47, 40, 42, 56, 16, 17, 15, 46, 5, 25, 29, 57, 10, 2, 35, 31, 45, 55, 4, 38, 58, 36, 44, 19, 11, 60, 34, 59, 30, 20, 9, 24, 51, 28, 50, 32, 48, 22, 43, 21, 12, 14, 27]) Will work with objId=7 >>> pfsConfig.select(catId=0, objId=7).fiberFlux [array([229086.765625])] >>> pfsConfig.select(catId=0, objId=7).filterNames [[<span class="code-quote">'i'</span>]] So our object is i = 18 mag. >>> pfsArm = butler.get(<span class="code-quote">"pfsArm"</span>, visit=47, arm=<span class="code-quote">"b"</span>).select(pfsConfig, objId=7, catId=0) >>> select = (pfsArm.wavelength > 500) & (pfsArm.wavelength < 600) >>> np.median(pfsArm.flux[select]/pfsArm.norm[select]) 0.14605088737010558 >>> pfsMerged = butler.get(<span class="code-quote">"pfsMerged"</span>, visit=47).select(pfsConfig, objId=7, catId=0) >>> select = (pfsMerged.wavelength > 500) & (pfsMerged.wavelength < 600) >>> np.median(pfsMerged.flux[select]) 5179.929950314969 >>> pfsSingle = butler.get(<span class="code-quote">"pfsSingle"</span>, catId=0, tract=0, patch=<span class="code-quote">"0,0"</span>, objId=7, visit=47) >>> select = (pfsSingle.wavelength > 500) & (pfsSingle.wavelength < 600) >>> np.median(pfsSingle.flux[select]) 0.14152226134165563 >>> pfsObject = butler.get(<span class="code-quote">"pfsObject"</span>, catId=0, tract=0, patch=<span class="code-quote">"0,0"</span>, objId=7, nVisit=6, pfsVisitHash=0x7ace412dc05971ff) >>> select = (pfsObject.wavelength > 500) & (pfsObject.wavelength < 600) >>> np.median(pfsObject.flux[select]) 0.0853505067399767 >>> pfsRef = butler.get(<span class="code-quote">"pfsReference"</span>, catId=0, tract=0, patch=<span class="code-quote">"0,0"</span>, objId=7) >>> select = (pfsRef.wavelength > 500) & (pfsRef.wavelength < 600) >>> np.median(pfsRef.flux[select]) 213332.26323327963 The pfsSingle flux is the same as the pfsArm flux, so it must be terribly wrong since pfsArm is uncalibrated and pfsSingle should be in nJy. Let<span class="code-quote">'s first look at the image to make sure there'</span>s a very bright trace where we expect. >>> pfsConfig.select(catId=0, objId=7).fiberId array([112], dtype=int32) >>> detMap = butler.get(<span class="code-quote">"detectorMap"</span>, visit=47, arm=<span class="code-quote">"r"</span>) There<span class="code-quote">'s definitely a brighter trace there. Not as bright as I thought it would be, but it'</span>s probably fine. Found a normalisation bug in fluxCalibrate. fluxCalibrate.py /scratch/pprice/jenkins/weekly/2021-09-19/process --calib=/scratch/pprice/jenkins/weekly/2021-09-19/process/CALIB --rerun=weekly/pipeline/brn/pipeline --doraise -j10 --id <span class="code-quote">'visit=47^48^49^53^54^57'</span> --no-versions coaddSpectra.py /scratch/pprice/jenkins/weekly/2021-09-19/process --calib=/scratch/pprice/jenkins/weekly/2021-09-19/process/CALIB --rerun=weekly/pipeline/brn/pipeline --doraise -j10 --id <span class="code-quote">'visit=47^48^49^53^54^57'</span> --no-versions Now: >>> np.median(pfsSingle.flux[select]) 213804.4453556766 >>> np.median(pfsObject.flux[select]) 212780.95413807267 </pre> </div></div> <p>Thanks Paul</p> <p>Merged.</p> Development Rank 0|02qpt6:508yl0chzzy000002js Reviewers hassan Sprint 2DDRP-2021 A 8 2DDRP-2021 A 9 Story Points 1.0