https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-889 DRP 2-D Pipeline <p>The method <tt>PfsConfig.selectByFiberStatus()</tt> returns indices of each fiberId specified, if that fiber has the corresponding <tt>FiberStatus</tt> matching that specified in the method argument.</p> <p>However the method does not behave as expected. The outputs of the following two lines should be the same:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> pfsConfig.selectFiber([3, 201, 649]) array([ 0, 84, 253]) pfsConfig.selectByFiberStatus(pfs.datamodel.FiberStatus.GOOD, [3, 201, 649]) array([0, 1, 2]) </pre> </div></div> PIPE2D-889

pfsConfig.selectByFiberStatus does not return the fiber indices

Bug Normal Won't Fix Won't Fix price hassan Mon, 23 Aug 2021 18:19:53 +0000 Mon, 23 Aug 2021 18:51:36 +0000 Mon, 23 Aug 2021 18:51:36 +0000 0 2 <p>This is behaving exactly as expected. <tt>pfsConfig.selectFiber(<span class="error">&#91;3, 201, 649&#93;</span>)</tt> returns the indices of the provided fiberIds. <tt>pfsConfig.selectByFiberStatus(pfs.datamodel.FiberStatus.GOOD, <span class="error">&#91;3, 201, 649&#93;</span>)</tt> returns the indices of fibers that are <tt>GOOD</tt> in the provided array, and since fibers 3, 201 and 649 are all <tt>GOOD</tt>, you get indices <tt>0, 1, 2</tt> (see <a href="https://github.com/Subaru-PFS/datamodel/blob/master/python/pfs/datamodel/pfsConfig.py#L627-L628" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/datamodel/blob/master/python/pfs/datamodel/pfsConfig.py#L627-L628</a>).</p> <p><tt>pfsConfig.selectByFiberStatus</tt> is from a while ago, and I don't think it's the most helpful. I now find myself using <tt>pfsConfig.select</tt> and <tt>pfsArm.select</tt> in most places I want to select fibers.</p> <p>You are right, sorry. The issue is in a different area with respect to <tt>DisplayDetectorMap</tt>. Closing ticket.</p> Relates PIPE2D-887 PIPE2D-888 Development Rank 0|zzs8yo: Sprint 2DDRP-2021 A 8 Story Points 1.0