https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-881 DRP 2-D Pipeline <p>Certain spots show ring like features in the residuals. This is due to the fact that the solution have not adapted to the new algorithm from <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-874" title="Centering/offset/interpolation - fix to PIPE2D 778 and PIPE2D-777" class="issue-link" data-issue-key="PIPE2D-874"><del>PIPE2D-874</del></a>. It seems that this is due to poor modelling of the struts (see defocused example.). See <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-700" title=" 2d-psf analysis - ring like feature in some of the residuals" class="issue-link" data-issue-key="PIPE2D-700"><del>PIPE2D-700</del></a> for prevous example of similar problem.</p> <p> </p> <p> </p> PIPE2D-881

Ring like residuals after PIPE2D-874

Task Normal Done Done ncaplar ncaplar Thu, 5 Aug 2021 16:06:10 +0000 Mon, 25 Oct 2021 23:40:13 +0000 Mon, 25 Oct 2021 23:40:13 +0000 0 3 <p>The reanalysis started today (sent to cluster on September 7) after the changes and improvements to the algorithm in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-880" title="Slow execution of Zernike algorithm after PIPE2D-874" class="issue-link" data-issue-key="PIPE2D-880"><del>PIPE2D-880</del></a> (internal version of Zernike_Module 0.48)</p> <p>First set of images and looks better. I have sent all the spots to be analyzed on the cluster. </p> <p>The analysis has finished and new results have been produced at /tigress/ncaplar/PFS/Fit_Results/Sep0521/ . The ``only'' thing left is to integrate them in the pipeline.</p> <p>I do not believe that there is actually review to be made, as no code has been changed - still, I am happy to go through formal procedure, if nothing else to exercise good practices. </p> <p>Changes look fine. No additional comments made for PR <a href="https://github.com/Subaru-PFS/drp_pfs_data/pull/15" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/drp_pfs_data/pull/15</a> .</p> <p>Reading this ticket I don't know what happened. Was there a problem? Is it fixed?</p> <p>Indeed, this is all very unclear as it has written here. The basic algorithm introduced in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-874" title="Centering/offset/interpolation - fix to PIPE2D 778 and PIPE2D-777" class="issue-link" data-issue-key="PIPE2D-874"><del>PIPE2D-874</del></a> was fine, but as I was rushing to create the solution in the previous ticket, I did very short runs where I was searching for new optimal parameters. As such, there were many locations the solution did not converge. I reran everything with longer running time and everything looks fine. So indeed there was no deep problem in the algorithm. That is partially why this ticket is poorly commented, as I did not give it much importance - but this has caused a lot of confusion.</p> Development Rank 0|zzs9y0: Reviewers hassan Sprint 2DDRP-2021 A 10 Story Points 6.0