PFS-JIRA

PFS-JIRA https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us

8.3.4

803005

13-09-2019

[PIPE2D-88] Fix indentation in Math.cc https://pfspipe.ipmu.jp/jira/browse/PIPE2D-88 DRP 2-D Pipeline PIPE2D-88

Fix indentation in Math.cc

Story Major Done Done aritter aritter Thu, 29 Sep 2016 18:40:46 +0000 Fri, 24 Feb 2017 07:13:18 +0000 Fri, 24 Feb 2017 07:13:18 +0000 0 2 indentations and deletion of commented out lines only. should be a quick review... Hey <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a>: this came up at today's meeting. Do you have an ETA on a review? Setting back to <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> for review. If this really is just an indentation cleanup, can I suggest re-starting from a merged HEAD? Especially if you are just using a program to reformat. The number of hard-to-judge "diff changes" in the first commit on <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-88" title="Fix indentation in Math.cc" class="issue-link" data-issue-key="PIPE2D-88"><del>PIPE2D-88</del></a> (46acb17) makes it hard for me to believe that it would merge to master cleanly. As an aside, I should look into how to adjust diff options to handle this kind of changeset. Much better, thanks. This is definitely cleanly reviewable and mergeable. Functionally, I check off on this. But: if you have a tool you can rerun with args, can you run with a line-length limit of 110 chars? There are quite a few long lines left, some exceeding 250 characters. That said, most of those are in very long <tt>cout <<</tt> lines. If those are to be replaced with a logger ticket it might not be worth it. Another note on the same subject: your formatter did insert indents for the namespaces: <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>#include "pfs/drp/stella/math/Math.h" namespace pfs { namespace drp { namespace stella { namespace math { template< typename T, typename U > [ ... ] </pre> </div></div> If there is an option to disable that you would lessen the visual price. I removed the line indent for the namespaces and filed a ticket to reduce the line length to the permitted 110 characters. Can I merge? Yes. Please do. Merged into master Development Rank 0|ii00v1: Reviewers cloomis Sprint 2014-16 Story Points 0.25