[PIPE2D-860] ReduceExposure fails with extra linesList argument to subtractSky2d.run

Mon, 28 Jun 2021 23:35:32 +0000

As reported by @ncaplar in the #princeton-pfs slack channel today:

As I briefly mentioned in 10am meeting, I am having some problems with reduceExposure. I wanted to first run sky2d subtraction on dcb data with 10 fibers, which previously worked. I ran reduceExposure.py /projects/HSC/PFS/Subaru --calib /projects/HSC/PFS/Subaru/CALIB-ncaplar --rerun /projects/HSC/PFS/Subaru/rerun/ncaplar/PIPE2D-857/ --id visit=34444 arm=r -c doMeasurePsf=True doSubtractSky2d=True doWriteCalexp=True subtractSky2d.useAllFibers=True, but I do get an error which I have placed at:
https://gist.github.com/nevencaplar/0fa12a5987a162dac587048385b06d09 . I get the same error when trying to do same on SuNNS data. I see that the number of arguments that self.subtractSky2d.run run takes has changed since March18, when is the last time I have in my records that we have been successfully running reduceExposure with 2d sky subtraction (and the fail error complains about number of arguments).

The last part of error stack trace is shown below:

reduceExposure FATAL: Failed on dataIds=[{'visit': 34444, 'arm': 'r', 'dateObs': '2020-11-14', 'site': 'S', 'category': 'A', 'spectrograph': 1, 'field': 'COMPARISON', 'ccd': 1, 'filter': 'r', 'expTime': 35.0, 'dataType': 'COMPARISON', 'taiObs': '2020-11-14T02:54:04.652', 'pfsDesignId': 1099528409104, 'slitOffset': 0.0}]: TypeError: run() takes 6 positional arguments but 7 were given
Traceback (most recent call last):
  File "/tigress/HSC/PFS/stack/20190925/stack/miniconda3-4.5.12-1172c30/Linux64/pipe_base/18.1.0/python/lsst/pipe/base/cmdLineTask.py", line 388, in __call__
    result = self.runTask(task, dataRef, kwargs)
  File "/tigress/HSC/PFS/stack/20190925/stack/miniconda3-4.5.12-1172c30/Linux64/pipe_base/18.1.0/python/lsst/pipe/base/cmdLineTask.py", line 447, in runTask
    return task.runDataRef(dataRef, **kwargs)
  File "/tigress/HSC/PFS/stack/20190925/stack/miniconda3-4.5.12-1172c30/Linux64/drp_stella/w.2021.25/python/pfs/drp/stella/reduceExposure.py", line 259, in runDataRef
    fiberTraceList, detectorMapList, linesList)
TypeError: run() takes 6 positional arguments but 7 were given

PFS-JIRA

[PIPE2D-860] ReduceExposure fails with extra linesList argument to subtractSky2d.run