https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-86 DRP 2-D Pipeline <p>Currently the pipeline assumes that pixel centers are at <span class="error">&#91;0.5,0.5&#93;</span> what is non-standard and can lead to confusion in ds9 and possibly in other packages. Please set the pixel centers to the standard <span class="error">&#91;0,0&#93;</span></p> PIPE2D-86

Change pixel centers from [0.5,0.5] to [0,0]

Story Major Done Done aritter aritter Wed, 28 Sep 2016 21:24:36 +0000 Thu, 22 Jun 2017 20:02:09 +0000 Thu, 22 Jun 2017 20:02:09 +0000 0 3 <p>Hey Andreas – what is "the pipeline" in this context? Is this just an assumption embedded in drp_stella, or will you be proposing changes to LSST code?</p> <p>drp_stella only. LSST I believe has the pixel centers at <span class="error">&#91;0,0&#93;</span></p> <p>I compared the new version to the old one and made sure that the resulting spectra and RMS of the wavelength solution are identical for both PIXEL_CENTER = 0.0 and 0.5.</p> <p>Note that I have filed the ticket <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-162" title="Confirm that PSF code works with new PixelCenter" class="issue-link" data-issue-key="PIPE2D-162"><del>PIPE2D-162</del></a> to go through the PSF code &amp; decide which parts should be kept. I also extended the ticket <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-129" title="Move code in SpectraTemplates.hpp to Spectra.cc. Same for PSF" class="issue-link" data-issue-key="PIPE2D-129"><del>PIPE2D-129</del></a> (move code from `SpectrumTemplates.hpp` to `Spectra.cc`) to `PSFTemplates.hpp`.</p> <p>I am not <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a> (to everybody's great relief, I'm sure), but my suggestion would be that you move all the "cleanup" work here onto a separate ticket. There are currently 28 separate commits in total, of which only about 7 or 8 seem relevant to the work actually being ticketed. Cleaning up formatting etc is nice, but a mountain of changes like this is much harder to review than a small, focused change.</p> <p>Here is an image showing the FiberTrace centers and limits:<br/> <span class="image-wrap" style=""><a id="10501_thumb" href="https://pfspipe.ipmu.jp/jira/secure/attachment/10501/10501_figure_1.png" title="figure_1.png" file-preview-type="image" file-preview-id="10501" file-preview-title="figure_1.png"><img src="https://pfspipe.ipmu.jp/jira/secure/thumbnail/10500/_thumb_10500.png" style="border: 0px solid black" /></a></span> </p> <p>And here an image showing a PSF extracted from multiple dithered PSF representations in one FiberTrace:<br/> <span class="image-wrap" style=""><a id="10501_thumb" href="https://pfspipe.ipmu.jp/jira/secure/attachment/10501/10501_figure_1.png" title="figure_1.png" file-preview-type="image" file-preview-id="10501" file-preview-title="figure_1.png"><img src="https://pfspipe.ipmu.jp/jira/secure/thumbnail/10501/_thumb_10501.png" style="border: 0px solid black" /></a></span> </p> <p>Currently the integration test in tests/testDRP.py still fails on modern Mac OS X due to SIP. This is getting fixed in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-53" title="tests/testDRP.py will fail on modern Mac OS" class="issue-link" data-issue-key="PIPE2D-53"><del>PIPE2D-53</del></a> which is currently in review. I can wait for <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-53" title="tests/testDRP.py will fail on modern Mac OS" class="issue-link" data-issue-key="PIPE2D-53"><del>PIPE2D-53</del></a> to get merged into master before I resubmit this ticket for review, or I could resubmit it now...?</p> <p>Does this ticket now pass all its tests?</p> <p>Also, looking at the changesets I wasn't sure if the fiber trace code still uses (0.0, 0.0) as the bottom left of a pixel internally. Does it? If so, please file a ticket to fix that.</p> <p>I strongly believe that nothing uses (0.0, 0.0) as the bottom left of a pixel anymore, not even internally. All tests are passing.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> Can you please send me the lines you wanted me look at?</p> <p>My concern was the routine <tt>ccdToFiberTraceCoordinates</tt> but now that I look more carefully I see that it's not converting between CCD and internal FiberTrace coordinates so that's OK.</p> <p>I don't understand why you need this function, as it looks to me like something that would have been naturally handled via a definition of <tt>dataXY::operator-</tt>, but that's out of scope. Actually, it only seems to be used in the PSF code which is slated for removal anyway so we definitely don't want to fix it.</p> <p>Good to merge then?</p> <p>Yes. I thought that was implicit from the comment, but apparently not.</p> <p>merged into master</p> Blocks PIPE2D-171 Relates PIPE2D-166 PIPE2D-167 PIPE2D-170 PIPE2D-171 PIPE2D-162 PIPE2D-165 Development Rank 0|ii00v2:x Reviewers price Sprint 2014-16 Story Points 2.0