https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-859 DRP 2-D Pipeline <p>With the current version of master branches, the weekly build fails. See error snippet below:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> ERROR: testObjectProducts (__main__.ProductionTestCase_bmn) Test that object products exist ---------------------------------------------------------------------- Traceback (most recent call last): File <span class="code-quote">"/scratch/pprice/jenkins/weekly/2021-06-20/build/stack/miniconda3-4.5.12-1172c30/Linux64/pfs_pipe2d/w.2021.25/python/pfs/pipe2d/weekly/test_weekly.py"</span>, line 49, in testObjectProducts <span class="code-keyword">for</span> target in self.design: TypeError: iter() returned non-iterator of type <span class="code-quote">'NotImplementedError'</span> </pre> </div></div> PIPE2D-859

Weekly build fails for w.2021.25

Task Major Done Done price hassan Mon, 21 Jun 2021 18:03:23 +0000 Tue, 29 Jun 2021 13:31:06 +0000 Tue, 29 Jun 2021 13:31:06 +0000 0 1 <p>Problem seems to be a consequence of the changes made in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-762" title="pfsConfig.selectFiber returns a transposed array with an extra dimension" class="issue-link" data-issue-key="PIPE2D-762"><del>PIPE2D-762</del></a>. With the changes made there, the return value of <tt>pfsDesign.selectFiber(fiberId)</tt> can now be a scalar as well as a sequence. A scalar return value its currently not supported in the 2D simulator (specifically <tt>lightSource.py</tt>), resulting in the failure.</p> <p>A fix has been pushed to the ticket branch of this issue. But this will be discussed with Paul Price this week to see whether this is better fixed in the datamodel code.</p> <p>Example simulator run demonstrating the problem:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> makeSim --visit 47 --detector r1 --pfsDesignId 1 --exptime 1800 --type object </pre> </div></div> <p>Run against weekly data (see eg <tt>/scratch/hassans/weekly/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-859" title="Weekly build fails for w.2021.25" class="issue-link" data-issue-key="PIPE2D-859"><del>PIPE2D-859</del></a></tt>).</p> <p>The weekly doesn't use the simulator (only its outputs), so we need to fix this in datamodel. I removed some functionality recently that apparently is used in testing the weekly, so it needs to go back in.</p> <p>But go ahead and merge the changes to drp_instmodel too: we're going to need them.</p> <p>Yes you are right, the issue with the simulator has nothing to do with the weekly builds. The simulator code has broken following the changes to the datamodel, but this is different to the problem with the weekly.</p> <p>I will merge the simulator problem as a separate ticket.</p> <p>Changes made by <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a> in datamodel to fix the failing weekly look fine to me.</p> <p>Merged.</p> Development Rank 0|02qpt6:508yl0chzzy0000026l Reviewers hassan Sprint 2DDRP-2021 A 6 Story Points 2.0