https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-846 DRP 2-D Pipeline <p>Make a skeleton of the flux calibration code in the pipeline based on the current codes (<a href="https://github.com/Subaru-PFS/drp_stella/blob/master/python/pfs/drp/stella/calculateReferenceFlux.py" class="external-link" rel="nofollow">calculateReferenceFlux</a> and <a href="https://github.com/Subaru-PFS/drp_stella/blob/master/python/pfs/drp/stella/fluxCalibrate.py" class="external-link" rel="nofollow">fluxCalibrate</a>) and a set of the codes in the flux calibration studies. The document of the skeleton will be provided. </p> <p> The attached file (fluxCalibrationFlow_20210525.pdf) is a current rough draft. In this version, the framework (or the process flow) in the existing codes in the pipeline is not considered yet. </p> <p> This task is addressed with the help of Mineo-san. </p> PIPE2D-846

Draw the skeleton of the code integration for the flux calibration

Story Normal Done Done Takuji Yamashita Takuji Yamashita flux-calibration Tue, 25 May 2021 02:16:03 +0000 Fri, 28 Jan 2022 17:16:27 +0000 Wed, 16 Jun 2021 00:13:55 +0000 0 5 <p>Here is an updated process flow of the flux calibration.</p> <p><span class="nobr"><a href="https://pfspipe.ipmu.jp/jira/secure/attachment/13885/13885_fluxCalibrationFlow_20210607.pdf" title="fluxCalibrationFlow_20210607.pdf attached to PIPE2D-846">fluxCalibrationFlow_20210607.pdf^{<img class="rendericon" src="https://pfspipe.ipmu.jp/jira/images/icons/link_attachment_7.gif" height="7" width="7" align="absmiddle" alt="" border="0"/>}</a></span></p> <p> </p> <p>The blue part is a set of tasks to find the best fit model of a flux standard, while the yellow is to apply the flux calibration to a science target. </p> <p>In the current pipeline, the main processes are done in fitReference.py and measureFluxCalibration.py. They are now placeholders. Individual tasks (square boxes in the flow chart) will be written either in fitReference.py or  measureFluxCalibration.py. The naming is tentative.  </p> <p> </p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a>, </p> <p>Does the updated flow chart include enough information to share the code integration concept and to be reviewed for you?</p> <p>We can discuss something about writing here with Mineo-san or do that when we need. </p> <p>It looks very reasonable.</p> <p>The flowcharts are enough to start writing codes. Should we directly modify the classes in drp_stella, or make subclasses to implement the flowcharts? In the latter case, should we add files to drp_stella or obs_pfs? If these codes work only for PFS (I don't know whether or not), will it still be OK for these codes to reside in drp_stella?</p> <p>I think you should start by subclassing. We can clobber the current code once you've demonstrated that it works on the simulated data.<br/> You can add data files to the drp_pfs_data package.</p> <p>Could you review the skeleton (fluxCalibrationFlow_20210607.pdf) of the flux calibration integration? </p> <p>I reviewed it previously, and it looks good.</p> <p>Thanks for your review. We close this ticket. </p> Development Epic Link PIPE2D-303 Rank 0|02qpq3:r2j Reviewers price