https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-845 DRP 2-D Pipeline <p>Following the discussion during the Princeton Group meeting 2021-05-17: please clarify the inputs, outputs and operations performed in the <tt>reduceExposure</tt> and <tt>reduceArc</tt> tasks in the context of arc line processing. </p> <p>Specifically:</p> <ul class="alternate" type="square"> <li>Specify where in the code the <tt>detectorMap</tt> is modified, and how (and is it overridden, stated in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-844" title="reduceExposure output detectorMap gets overriden" class="issue-link" data-issue-key="PIPE2D-844"><del>PIPE2D-844</del></a>?)</li> <li>Specify where the <tt>arcLines</tt> output is generated, and the inputs and algorithm used to generate this product. And again, if these are generated by <tt>reduceExposure</tt>, are they overridden in <tt>reduceArc</tt>??</li> </ul> <p>This information can be provided as comments in this ticket, for the time being. If the approach is agreed within the Princeton Group, the design document should be updated.</p> PIPE2D-845

Clarify the operations of reduceArc and reduceExposure

Task Normal Done Done price hassan Sun, 23 May 2021 23:34:55 +0000 Wed, 4 Aug 2021 21:33:33 +0000 Wed, 4 Aug 2021 21:33:33 +0000 0 2 <p><tt>ReduceExposureTask</tt> is the general workhorse for reducing an exposure. For this reason, it is used as a sub-task by <tt>ReduceArcTask</tt>. <tt>ReduceExposureTask</tt> operates on a list of all arms of the same kind within a single visit (e.g., r1,r2,r3,r4). The following list of operations is correct following the changes made in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-829" title="Investigate/fix line intensity measurements" class="issue-link" data-issue-key="PIPE2D-829"><del>PIPE2D-829</del></a>:</p> <ul> <li>Instrument signature removal and repair (CR masking, static bad pixels)</li> <li>Wrangle spectral calibs: <ul> <li>fiberProfiles --&gt; fiberTraces</li> <li>Measure line centroids</li> <li>detectorMap <ul> <li>Perform low-order adjustment</li> <li>Write adjusted detectorMap as "detectorMap_used"</li> <li>Regenerate fiberTraces</li> </ul> </li> <li>Measure line fluxes</li> </ul> </li> <li>Measure PSF and resulting LSF</li> <li>2D sky subtraction</li> <li>Extract spectrum <ul> <li>Optional 2D continuum subtraction</li> </ul> </li> <li>Write outputs: <ul> <li>"calexp": exposure, possibly with 2D continuum subtracted</li> <li>"pfsArmLsf": line-spread function</li> <li>"sky2d": 2D sky subtraction model</li> <li>"pfsArm": extracted spectra</li> <li>"arcLines": line centroids+fluxes</li> </ul> </li> </ul> <p><tt>ReduceArcTask</tt> runs <tt>ReduceExposureTask</tt>, collects the arcLines from different visits, fits a detectorMap and writes (as the "detectorMap" dataset). One wrinkle is that the file template for this is currently the same as for the "detectorMap_used" dataset. The filename does have to be the same (because of current limitations in the datamodel implementation), but we could write it to a different directory (but currently don't).</p> <p>This documentation needs to go somewhere "official", probably the <a href="https://github.com/Subaru-PFS/drp_doc/tree/master/pipelineUser" class="external-link" rel="nofollow">"pipeline user"</a> docs.</p> <p>Also need to provide clear documentation on the steps needed to produce good calibs before running reduceExposure (bias, dark, flat, bootstrap, fiberProfile, reduceArc, fiberProfile, reduceArc).</p> <p>Describe the detectorMap model in some detail.</p> <p>I've updated the pipeline user doc: <a href="https://github.com/Subaru-PFS/drp_doc/pull/4" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/drp_doc/pull/4</a></p> <p>Changes look good. Only minor comments added to pull request.</p> <p>Merged. <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a>, could you please ensure the updated PDF is posted wherever the Right Place is?</p> Relates PIPE2D-844 Development Rank 0|02qpt6:508yl0chzzy00000ywi Reviewers hassan Sprint 2DDRP-2021 A5 2DDRP-2021 A 6 2DDRP-2021 A 7 2DDRP-2021 A 8 Story Points 2.0