https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-843 DRP 2-D Pipeline <p>The headerFix mechanism captures essential fixes to the raw data. A few fixes are in code, in obs/pfs/headerFixes.py. The rest are in data files. Those should be accreted into some instrument-wide repo so they get applied everywhere.</p> <p>[ LAM is as I write taking sm3 data using r2. At the very least there will be W_PFDSGN fixes. ]</p> PIPE2D-843

Persist headerFix edits in common repo.

Task Normal Done Done price cloomis Wed, 19 May 2021 14:21:40 +0000 Fri, 28 Jan 2022 17:16:27 +0000 Wed, 4 Aug 2021 22:34:09 +0000 0 3 <p>Right now we have yaml files in <tt>$OBS_PFS_DIR/corrections</tt> at Princeton. The filenames are <tt>PFS-$visit.yaml</tt>. The files are not checked in.</p> <p>We probably want per-site directories in some instdata product, since LAM visits are not independent of Subaru visits. Arguable.</p> <p>Oh, should the files actually be <tt>PFS-$visit-$arm.yaml</tt>?</p> <p>The authoritative source for header fixes is <a href="https://github.com/Subaru-PFS/obs_pfs/blob/master/python/lsst/obs/pfs/headerFixes.py" class="external-link" rel="nofollow">in the code</a>, from which the yaml files are generated. Should we just move <tt>headerFixes.py</tt> to pfs&#95;utils? Then you can add whatever interface you need for other work.</p> <p>Asking <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a> to review the code, and <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> to check that this solution works for him.</p> <p>Code changes look fine to me. As Paul mentions, Craig needs to verify the solution works.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> noted that the current solution doesn't work in general because we have multiple sites with independent <tt>visit</tt> counters. However, I'm going to merge this because it's the current solution (this ticket merely moves where that solution lives, making the limited solution available to more parties which is potentially a good thing), and leave it to wiser heads than mine to decide if and when we need a more complete solution.</p> <p>Merged.</p> Development Rank 0|02qpq3:r2i Reviewers hassan