<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 15:58:34 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[PIPE2D-830] Fix breakage in mergeArms</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/PIPE2D-830</link>
                <project id="10002" key="PIPE2D">DRP 2-D Pipeline</project>
                    <description>&lt;p&gt;&lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl&quot; class=&quot;user-hover&quot; rel=&quot;rhl&quot;&gt;rhl&lt;/a&gt; writes:&lt;/p&gt;
&lt;blockquote&gt;
&lt;p&gt;I&apos;m having trouble reducing SuNSS data with master.  I built new fiberTraces using &lt;tt&gt;constructFiberProfiles.py /projects/HSC/PFS/Subaru &amp;#45;&amp;#45;calib /projects/HSC/PFS/Subaru/CALIB-SuNSS &amp;#45;&amp;#45;id visit=46629..46649 &amp;#45;&amp;#45;rerun rhl/sunss &amp;#45;&amp;#45;batch-type none -c isr.doFlat=False isr.doDefect=False isr.doDark=False isr.doBrokenRedShutter=True isr.brokenRedShutter.useAnalytic=True isr.brokenRedShutter.checkParallelOverscan=True psfFwhm=3 forceFiberIds=True profiles.doBlindFind=False profiles.centroidRadius=3 profiles.profileRadius=3 rerunISR=False -j 20&lt;/tt&gt; (followed by ingest), but when I run reduceExposure and mergeArms I get this error.  Looking at the pfsArm files in the r only shows around 5 spectra, possibly those which happen to have signal down the fibres.&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt; 
$ reduceExposure.py /projects/HSC/PFS/Subaru --calib /projects/HSC/PFS/Subaru/CALIB-SuNSS --rerun rhl/sunss -c doWriteCalexp=True isr.doFlat=False isr.doDefect=False isr.doDark=False repair.interp.modelPsf.defaultFwhm=2.25
$ mergeArms.py /projects/HSC/PFS/Subaru --calib /projects/HSC/PFS/Subaru/CALIB-SuNSS --rerun rhl/sunss --id visit=46032 -c doBarycentricCorr=False doSubtractSky1d=False 
mergeArms WARN: Set of fiberIds of LSFs != fiberIds &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; spectra:  Only in fiberId: {512, 514, 3, 6, 518, 520, 9, 522, 12, 15, 527, 529, 18, 532, 21, 535, 24, 537, 27, 540, 30, 543, 32, 546, 35, 549, 38, 552, 41, 555, 46, 558, 49, 563, 52, 565, 55, 567, 58, 570, 572, 61, 574, 576, 66, 579, 69, 582, 72, 585, 75, 589, 78, 592, 81, 595, 84, 598, 87, 601, 90, 604, 95, 609, 98, 612, 101, 615, 104, 618, 107, 621, 110, 623, 113, 625, 627, 116, 630, 119, 632, 122, 634, 124, 636, 127, 639, 130, 642, 133, 645, 647, 649, 138, 141, 144, 147, 150, 153, 155, 156, 157, 158, 159, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 187, 189, 191, 193, 195, 197, 199, 201, 203, 205, 208, 210, 212, 215, 217, 219, 221, 223, 225, 227, 231, 233, 235, 238, 240, 242, 245, 247, 249, 251, 253, 257, 259, 261, 263, 266, 268, 270, 275, 278, 281, 284, 287, 290, 293, 296, 299, 302, 304, 306, 308, 311, 313, 315, 338, 341, 344, 347, 349, 351, 354, 357, 360, 363, 366, 369, 372, 375, 378, 381, 385, 387, 389, 391, 393, 395, 397, 399, 403, 406, 408, 410, 413, 415, 417, 419, 421, 423, 425, 429, 431, 433, 436, 438, 440, 443, 445, 447, 449, 451, 453, 455, 457, 459, 461, 466, 468, 474, 477, 479, 482, 485, 488, 491, 494, 497, 500, 502, 504, 506, 508, 510} (fixing) Only in armPsf: {192, 2, 339, 650}
mergeArms WARN: Set of fiberIds of LSFs != fiberIds &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; spectra:  Only in fiberId: {512, 514, 3, 6, 518, 520, 9, 522, 12, 15, 527, 529, 18, 532, 21, 535, 24, 537, 27, 540, 30, 543, 32, 546, 35, 549, 38, 552, 41, 555, 46, 558, 49, 563, 52, 565, 55, 567, 58, 570, 572, 61, 574, 576, 66, 579, 69, 582, 72, 585, 75, 589, 78, 592, 81, 595, 84, 598, 87, 601, 90, 604, 95, 609, 98, 612, 101, 615, 104, 618, 107, 621, 110, 623, 113, 625, 627, 116, 630, 119, 632, 122, 634, 124, 636, 127, 639, 130, 642, 133, 645, 647, 649, 138, 141, 144, 147, 150, 153, 155, 156, 157, 158, 159, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 187, 189, 191, 193, 195, 197, 199, 201, 203, 205, 208, 210, 212, 215, 217, 219, 221, 223, 225, 227, 231, 233, 235, 238, 240, 242, 245, 247, 249, 251, 253, 257, 259, 261, 263, 266, 268, 270, 275, 278, 281, 284, 287, 290, 293, 296, 299, 302, 304, 306, 308, 311, 313, 315, 338, 341, 344, 347, 349, 351, 354, 357, 360, 363, 366, 369, 372, 375, 378, 381, 385, 387, 389, 391, 393, 395, 397, 399, 403, 406, 408, 410, 413, 415, 417, 419, 421, 423, 425, 429, 431, 433, 436, 438, 440, 443, 445, 447, 449, 451, 453, 455, 457, 459, 461, 466, 468, 474, 477, 479, 482, 485, 488, 491, 494, 497, 500, 502, 504, 506, 508, 510} (fixing) Only in armPsf: {192, 2, 339, 650}
/home/rhl/PFS/drp/stella/python/pfs/drp/stella/datamodel/interpolate.py:61: RuntimeWarning: invalid value encountered in greater
  intIndex[(intIndex == index) &amp;amp; (index &amp;gt; 0)] -= 1  # Linear interpolation takes the index before
Traceback (most recent call last):
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/tigress/HSC/PFS/stack/current/stack/current/Linux64/pipe_base/18.1.0/python/lsst/pipe/base/cmdLineTask.py&quot;&lt;/span&gt;, line 388, in __call__
    result = self.runTask(task, dataRef, kwargs)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/tigress/HSC/PFS/stack/current/stack/current/Linux64/pipe_base/18.1.0/python/lsst/pipe/base/cmdLineTask.py&quot;&lt;/span&gt;, line 447, in runTask
    &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; task.runDataRef(dataRef, **kwargs)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/home/rhl/PFS/drp/stella/python/pfs/drp/stella/mergeArms.py&quot;&lt;/span&gt;, line 175, in runDataRef
    results = self.run(spectra, pfsConfig, lsfList)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/home/rhl/PFS/drp/stella/python/pfs/drp/stella/mergeArms.py&quot;&lt;/span&gt;, line 125, in run
    lsfList = [self.mergeLsfs(ll, ss) &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; ll, ss in zip(lsfList, spectra)]
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/home/rhl/PFS/drp/stella/python/pfs/drp/stella/mergeArms.py&quot;&lt;/span&gt;, line 125, in &amp;lt;listcomp&amp;gt;
    lsfList = [self.mergeLsfs(ll, ss) &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; ll, ss in zip(lsfList, spectra)]
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/home/rhl/PFS/drp/stella/python/pfs/drp/stella/mergeArms.py&quot;&lt;/span&gt;, line 299, in mergeLsfs
    &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; {ff: coaddLsf([ww[ff] &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; ww in warpedLsfList]) &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; ff in fiberId}
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/home/rhl/PFS/drp/stella/python/pfs/drp/stella/mergeArms.py&quot;&lt;/span&gt;, line 299, in &amp;lt;dictcomp&amp;gt;
    &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; {ff: coaddLsf([ww[ff] &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; ww in warpedLsfList]) &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; ff in fiberId}
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/home/rhl/PFS/drp/stella/python/pfs/drp/stella/mergeArms.py&quot;&lt;/span&gt;, line 299, in &amp;lt;listcomp&amp;gt;
    &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; {ff: coaddLsf([ww[ff] &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; ww in warpedLsfList]) &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; ff in fiberId}
KeyError: 2
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;&lt;/blockquote&gt;</description>
                <environment></environment>
        <key id="15586">PIPE2D-830</key>
            <summary>Fix breakage in mergeArms</summary>
                <type id="10001" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10515&amp;avatarType=issuetype">Story</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="price">price</assignee>
                                    <reporter username="price">price</reporter>
                        <labels>
                    </labels>
                <created>Wed, 5 May 2021 14:31:10 +0000</created>
                <updated>Fri, 7 May 2021 14:47:22 +0000</updated>
                            <resolved>Fri, 7 May 2021 14:47:22 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                <comments>
                            <comment id="19270" author="price" created="Wed, 5 May 2021 16:21:52 +0000"  >&lt;p&gt;The problem is that the &lt;tt&gt;fiberProfiles&lt;/tt&gt;&#160;used for &lt;tt&gt;visit=46032&lt;/tt&gt; is &lt;tt&gt;/projects/HSC/PFS/Subaru/CALIB-SuNSS/FIBERPROFILES/pfsFiberProfiles-2021-01-16-041373-b1.fits&lt;/tt&gt;, which was constructed with &lt;tt&gt;visit=41373^41380^41417^41424^41431^41438^41445^41452^41459^41466^41473&lt;/tt&gt;. These visits are DCB data, and not SuNSS:&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
sqlite&amp;gt; SELECT DISTINCT visit, pfsDesignId FROM raw WHERE visit IN (41373,41380,41417,41424,41431,41438,41445,41452,41459,41466,41473);
41373|1099528409104
41380|1099528409104
41417|1099528409104
41424|1099528409104
41431|1099528409104
41438|1099528409104
41445|1099528409104
41452|1099528409104
41459|1099528409104
41466|1099528409104
41473|1099528409104

&amp;gt;&amp;gt;&amp;gt; DummyCableBDatabase().interpret(1099528409104)
[&lt;span class=&quot;code-quote&quot;&gt;&apos;green&apos;&lt;/span&gt;, &lt;span class=&quot;code-quote&quot;&gt;&apos;red1&apos;&lt;/span&gt;, &lt;span class=&quot;code-quote&quot;&gt;&apos;red4&apos;&lt;/span&gt;, &lt;span class=&quot;code-quote&quot;&gt;&apos;red8&apos;&lt;/span&gt;]
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;How do we prevent this from happening? We would need to include some state in the &lt;tt&gt;dataId&lt;/tt&gt; for the calib. At the present time, perhaps the best choice is the &lt;tt&gt;pfsDesignId&lt;/tt&gt; (which presently tells us which fibers are illuminated), but that may or may not be something we want for operations.&lt;/p&gt;</comment>
                            <comment id="19291" author="rhl" created="Fri, 7 May 2021 12:52:02 +0000"  >&lt;p&gt;We discussed this on slack, and realised that we can detect this piece of user error in &lt;tt&gt;reduceExposure&lt;/tt&gt;.  As soon as that ticket is filed, we can close this one.&lt;/p&gt;</comment>
                            <comment id="19295" author="price" created="Fri, 7 May 2021 14:01:25 +0000"  >&lt;p&gt;I think I&apos;ve already implemented the changes on this ticket branch. Hope to submit for review soon.&lt;/p&gt;</comment>
                            <comment id="19298" author="price" created="Fri, 7 May 2021 14:19:51 +0000"  >&lt;p&gt;Passed integration test and ready for review.&lt;/p&gt;</comment>
                            <comment id="19299" author="hassan" created="Fri, 7 May 2021 14:38:32 +0000"  >&lt;p&gt;Review done. Changes look fine.&lt;/p&gt;</comment>
                            <comment id="19301" author="price" created="Fri, 7 May 2021 14:47:22 +0000"  >&lt;p&gt;Merged.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|02qpt6:508yl0chzzy000002ji</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>hassan</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10005" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="105">2DDRP-2021 A 4</customfieldvalue>
    <customfieldvalue id="109">2DDRP-2021 A5</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    </customfields>
    </item>
</channel>
</rss>