https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-826 DRP 2-D Pipeline <p>It appears that even if there not used, 3 slit have 600 fibers instead of 2.</p> <p>DetectorMap should be updated according. <font color="#1d1c1d">The pfsConfig then tells you what the fibres are used for (or if they're broken, or unassigned, or ...)</font></p> <p> </p> <p>see <font color="#1d1c1d"><a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1195" title="Update grandfibermap following the recent discussions and requests" class="issue-link" data-issue-key="INSTRM-1195"><del>INSTRM-1195</del></a></font></p> <p>and <a href="https://pfs.ipmu.jp/internal/bts/show_bug.cgi?id=863" class="external-link" rel="nofollow">https://pfs.ipmu.jp/internal/bts/show_bug.cgi?id=863</a></p> PIPE2D-826

Update detectorMap to add all fibers really present in a slit

Task Normal Done Done price fmadec Tue, 27 Apr 2021 15:39:33 +0000 Thu, 29 Apr 2021 19:53:38 +0000 Thu, 29 Apr 2021 19:53:38 +0000 0 3 <p>Currently:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> &gt;&gt;&gt; <span class="code-keyword">for</span> xx in product(<span class="code-quote">"brnm"</span>, <span class="code-quote">"1234"</span>): ... detMap = DetectorMap.readFits(f<span class="code-quote">"drp_pfs_data/detectorMap/detectorMap-sim-{''.join(xx)}.fits"</span>) ... print(xx, detMap.fiberId.min(), detMap.fiberId.max(), detMap.fiberId.size) ... (<span class="code-quote">'b'</span>, <span class="code-quote">'1'</span>) 2 650 600 (<span class="code-quote">'b'</span>, <span class="code-quote">'2'</span>) 653 1301 600 (<span class="code-quote">'b'</span>, <span class="code-quote">'3'</span>) 1304 1952 597 (<span class="code-quote">'b'</span>, <span class="code-quote">'4'</span>) 1955 2603 597 (<span class="code-quote">'r'</span>, <span class="code-quote">'1'</span>) 2 650 600 (<span class="code-quote">'r'</span>, <span class="code-quote">'2'</span>) 653 1301 600 (<span class="code-quote">'r'</span>, <span class="code-quote">'3'</span>) 1304 1952 597 (<span class="code-quote">'r'</span>, <span class="code-quote">'4'</span>) 1955 2603 597 (<span class="code-quote">'n'</span>, <span class="code-quote">'1'</span>) 2 650 600 (<span class="code-quote">'n'</span>, <span class="code-quote">'2'</span>) 653 1301 600 (<span class="code-quote">'n'</span>, <span class="code-quote">'3'</span>) 1304 1952 597 (<span class="code-quote">'n'</span>, <span class="code-quote">'4'</span>) 1955 2603 597 (<span class="code-quote">'m'</span>, <span class="code-quote">'1'</span>) 2 650 600 (<span class="code-quote">'m'</span>, <span class="code-quote">'2'</span>) 653 1301 600 (<span class="code-quote">'m'</span>, <span class="code-quote">'3'</span>) 1304 1952 597 (<span class="code-quote">'m'</span>, <span class="code-quote">'4'</span>) 1955 2603 597 </pre> </div></div> <p>See also <a href="https://sumire.pbworks.com/w/file/fetch/142768458/fiber_routing_YMoritani_20210110.pdf" class="external-link" rel="nofollow">https://sumire.pbworks.com/w/file/fetch/142768458/fiber_routing_YMoritani_20210110.pdf</a><br/> SM2 consists of 597 fibres, the rest 600.</p> <p>Added all fiber holes to all detectorMaps. The pfsConfig will tell us which are illuminated.</p> <p>Demonstrating that the new detectorMaps contain all (science) fiber holes:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> &gt;&gt;&gt; from itertools <span class="code-keyword">import</span> product &gt;&gt;&gt; from pfs.drp.stella <span class="code-keyword">import</span> DetectorMap &gt;&gt;&gt; <span class="code-keyword">for</span> xx in product(<span class="code-quote">"brnm"</span>, <span class="code-quote">"1234"</span>): ... detMap = DetectorMap.readFits(f<span class="code-quote">"detectorMap-sim-{''.join(xx)}.fits"</span>) ... print(xx, detMap.fiberId.min(), detMap.fiberId.max(), detMap.fiberId.size) ... (<span class="code-quote">'b'</span>, <span class="code-quote">'1'</span>) 2 650 600 (<span class="code-quote">'b'</span>, <span class="code-quote">'2'</span>) 653 1301 600 (<span class="code-quote">'b'</span>, <span class="code-quote">'3'</span>) 1304 1952 600 (<span class="code-quote">'b'</span>, <span class="code-quote">'4'</span>) 1955 2603 600 (<span class="code-quote">'r'</span>, <span class="code-quote">'1'</span>) 2 650 600 (<span class="code-quote">'r'</span>, <span class="code-quote">'2'</span>) 653 1301 600 (<span class="code-quote">'r'</span>, <span class="code-quote">'3'</span>) 1304 1952 600 (<span class="code-quote">'r'</span>, <span class="code-quote">'4'</span>) 1955 2603 600 (<span class="code-quote">'n'</span>, <span class="code-quote">'1'</span>) 2 650 600 (<span class="code-quote">'n'</span>, <span class="code-quote">'2'</span>) 653 1301 600 (<span class="code-quote">'n'</span>, <span class="code-quote">'3'</span>) 1304 1952 600 (<span class="code-quote">'n'</span>, <span class="code-quote">'4'</span>) 1955 2603 600 (<span class="code-quote">'m'</span>, <span class="code-quote">'1'</span>) 2 650 600 (<span class="code-quote">'m'</span>, <span class="code-quote">'2'</span>) 653 1301 600 (<span class="code-quote">'m'</span>, <span class="code-quote">'3'</span>) 1304 1952 600 (<span class="code-quote">'m'</span>, <span class="code-quote">'4'</span>) 1955 2603 600 </pre> </div></div> <p>Looks fine. See minor comment about docString.</p> <p>Cleaned up and merged.</p> Development Rank 0|02qpt6:508yl0chzzy0000026i Reviewers hassan Sprint 2DDRP-2021 A 4 Story Points 2.0