https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-813 DRP 2-D Pipeline <p>The <tt>str</tt> method of <tt>FiberStatus</tt> and <tt>TargetType</tt> return things like <tt>FiberStatus.BROKENFIBER</tt>; please change this to <tt>BROKENFIBER</tt>. If you want <tt>repr</tt> you know where to find it.</p> PIPE2D-813

Make str more useful for pfsConfig enums

Story Normal Done Done rhl rhl Fri, 16 Apr 2021 15:19:25 +0000 Sat, 17 Apr 2021 20:14:25 +0000 Sat, 17 Apr 2021 20:14:25 +0000 0 2 <p>Trivial.</p> <p><a href="https://github.com/Subaru-PFS/datamodel/pull/69" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/datamodel/pull/69</a></p> <p>I'm not sure this is good (<tt>"BROKENFIBER"</tt> doesn't communicate that this is an <tt>enum</tt> instance rather than a string), but if it's what you want then OK. But why is this more involved than:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> def __str__(self): <span class="code-quote">"""Stringify"</span>"" <span class="code-keyword">return</span> self.name </pre> </div></div> <p>?</p> <p>That's a much better implementation, I'll fix it.</p> <p>It's better because I want to ask what a fibre is, and don't care that it's an enum. If I want to know that, I'll use <tt>repr</tt>.</p> <p>merged and pushed</p> Development Rank 0|zzs4wk: Reviewers price Sprint 2DDRP-2021 A 4 Story Points 1.0