https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-804 DRP 2-D Pipeline <p>The current broken shutter code has two modes, reading and subtracting a bias and using an analytical model of the readout. The former has not been extensively used and is a nuisance as it cannot fit cleanly in the <tt>IsrTask</tt> as it has to hunt for a suitable bias exposure taken close to the data frame. The latter appears to work well.<br/> We expect to replace the shutter within a few days, but I am not convinced that the problem won't reappear in the future; additionally the analytic version can be used from notebooks to produce a fast reduction on the mountain for e.g. "IFU images".<br/> Please move the analytic code into the Task proper; we can postpone the possible removal of the bias-based code to another time.</p> PIPE2D-804

Simplify the broken-shutter analytic-corrections code

Story Normal Done Done rhl rhl Thu, 1 Apr 2021 20:56:41 +0000 Fri, 2 Apr 2021 19:28:04 +0000 Fri, 2 Apr 2021 19:28:04 +0000 obs_pfs 0 2 <p><a href="https://github.com/Subaru-PFS/obs_pfs/pull/96" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/obs_pfs/pull/96</a></p> <p>Changes look fine. Only minor comments on docString and replacing certain print calls with logging calls. But these can be deferred to a later ticket if these changes need to be put into master promptly.</p> <p>I didn't formally put it up for review yet, but thanks! I responded to your comments, merged to master, and pushed.</p> Development Rank 0|zzs4ug: Reviewers hassan