https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-793 DRP 2-D Pipeline <p>Updated sky subtraction code so that it can handle SuNNs data. At the moment, the code works by comparing position of the spot on the detector and provided locations in the 2d psf array and searching for nearest given the `xMaxDistance` parameter (see <a href="https://github.com/Subaru-PFS/drp_stella/blob/91432e704b39c1842f109b24e808a34e8332f796/python/pfs/drp/stella/NevenPsfContinued.py#L53" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/drp_stella/blob/91432e704b39c1842f109b24e808a34e8332f796/python/pfs/drp/stella/NevenPsfContinued.py#L53</a>). </p> <p>We should change the code that it works via a proper fiber identification mechanism, requesting the solutions from the provided array of 2d point spread function via fiber id. This will probably involve some work and planning by both me and <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a> .</p> PIPE2D-793

Update sky subtraction to work across all fiber configurations

Task Normal Done Done price ncaplar Tue, 23 Mar 2021 13:03:17 +0000 Fri, 18 Jun 2021 13:15:03 +0000 Thu, 10 Jun 2021 17:25:32 +0000 0 3 <p>After consultations with Paul, I have uploaded a new code (/tigress/ncaplar/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-793" title="Update sky subtraction to work across all fiber configurations" class="issue-link" data-issue-key="PIPE2D-793"><del>PIPE2D-793</del></a>) which takes as input wavelength and fiber, as well as test cases. This is now being implemented in C and pipeline by Paul.</p> <p>Re-assigned to Paul as he will take care of the pipeline updates.</p> <p>What is the desired behaviour when the user requests the PSF for a fiber without a PSF solution? The reference implementation returns the PSF for the closest fiber and warns "this is probably not what you want". In order to protect the user from getting strange results, I currently have the pipeline code throwing an exception.</p> <p>I think that is ok.</p> <p> </p> <p>Thanks. Then I think this is ready to be reviewed.</p> <p>Changes look fine. You mention in one of the commits that you "managed to improve the interpolation precision from 1e-8 to 1e-9" . Do you have code/plots that demonstrate that?</p> <p>The <a href="https://github.com/Subaru-PFS/drp_stella/pull/195/commits/b1508ad9f0f516f5af01628fa2f5e2acd9dadd1b#diff-b0a4b14575fabf8d58dc215a580272b1c6fb213f030ffa0ace7e4894b3fff4b0L127-R109" class="external-link" rel="nofollow">test of fidelity to Neven’s reference implementation</a> has had the precision tightened from 1e-8 to 1e-9.</p> <p>Merged.</p> Blocks PIPE2D-857 Development Rank 0|02qpt6:508yl0chzzy00000yxw Reviewers hassan Sprint 2DDRP-2021 A5 2DDRP-2021 A 6 Story Points 3.0