https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-792 DRP 2-D Pipeline <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> reduceArc.py /projects/HSC/PFS/Subaru --calib /scratch/pprice/pipe2d-706/CALIB --rerun rhl/stability -c reduceExposure.isr.doFlat=False reduceExposure.useCalexp=True readLineList.restrictByLamps=False fitDetectorMap.soften=0.2 identifyLines.findLines.doSubtractContinuum=True identifyLines.findLines.threshold=10 reduceExposure.doOffsetDetectorMap=False doUpdateDetectorMap=True fitDetectorMap.doSlitOffsets=True identifyLines.findLines.fittingRadius=2 --id arm=b^r visit=41374..41377^41381..41384^41418..41421^41425..41428 -j 20</pre> </div></div> <p>should generate a good detectorMap from a set of Ar/Ne/Kr/ArHg lines. However, when I look at the offsets from the resulting detectorMap it seems that fiberId 464 is off by c. 0.025 pixels in x (see <span class="image-wrap" style=""><a id="13439_thumb" href="https://pfspipe.ipmu.jp/jira/secure/attachment/13439/13439_stabilityDetMap.png" title="stabilityDetMap.png" file-preview-type="image" file-preview-id="13439" file-preview-title="stabilityDetMap.png"><img src="https://pfspipe.ipmu.jp/jira/secure/thumbnail/13439/_thumb_13439.png" style="border: 0px solid black" /></a></span> ).</p> <p>Note that <tt>fitDetectorMap.doSlitOffsets=True</tt> so I <em>am</em> expecting to update the slit offsets in this case.</p> PIPE2D-792

DetectorMap updated using reduceArc doesn't capture slit offsets

Story Normal Won't Fix Won't Fix price rhl Mon, 22 Mar 2021 18:50:07 +0000 Fri, 26 Mar 2021 16:11:51 +0000 Fri, 26 Mar 2021 16:11:51 +0000 0 2 <p>I can't reproduce this. I wonder if you're reading the correct detectorMap?</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> reduceArc.py /projects/HSC/PFS/Subaru --calib /scratch/pprice/pipe2d-706/CALIB --rerun price/pipe2d-792 -c reduceExposure.isr.doFlat=False reduceExposure.useCalexp=True readLineList.restrictByLamps=False fitDetectorMap.soften=0.2 identifyLines.findLines.doSubtractContinuum=True identifyLines.findLines.threshold=10 reduceExposure.doOffsetDetectorMap=False doUpdateDetectorMap=True fitDetectorMap.doSlitOffsets=True identifyLines.findLines.fittingRadius=2 --id arm=r visit=41374..41377^41381..41384^41418..41421^41425..41428 -j 20 reduceArc.fitDetectorMap INFO: Final fit: chi2=1562.356214 dof=5298 xRMS=0.046792 yRMS=0.150495 (0.012952 nm, 4.836037 km/s) from 2667/2738 lines reduceArc.fitDetectorMap INFO: Fit quality from reserved lines: chi2=317.102439 xRMS=0.027624 yRMS=0.055329 (0.004762 nm, 1.777947 km/s) from 303 lines (10.0%) reduceArc.fitDetectorMap INFO: Softening errors by 0.068387 pixels (0.005886 nm, 2.197560 km/s) to yield chi^2/dof=1 reduceArc.fitDetectorMap INFO: Softened fit: chi2=5158.014724 dof=5298 xRMS=0.035890 yRMS=0.098473 (0.008475 nm, 3.164337 km/s) from 2667/3041 lines reduceArc.fitDetectorMap INFO: Softened fit quality from reserved lines: chi2=1426.640587 xRMS=0.026431 yRMS=0.051665 (0.004446 nm, 1.660197 km/s) from 303 lines (10.0%) &gt;&gt;&gt; from lsst.daf.persistence <span class="code-keyword">import</span> Butler &gt;&gt;&gt; from pfs.drp.stella <span class="code-keyword">import</span> DetectorMap &gt;&gt;&gt; butler = Butler(<span class="code-quote">"/projects/HSC/PFS/Subaru/rerun/price/pipe2d-792"</span>) &gt;&gt;&gt; lines = butler.get(<span class="code-quote">"arcLines"</span>, visit=41374, arm=<span class="code-quote">"r"</span>) &gt;&gt;&gt; detMap = DetectorMap.readFits(<span class="code-quote">"/projects/HSC/PFS/Subaru/rerun/price/pipe2d-792/DETECTORMAP/pfsDetectorMap-041374-r1.fits"</span>) &gt;&gt;&gt; xyFit = detMap.findPoint(lines.fiberId, lines.wavelength) &gt;&gt;&gt; select = lines.fiberId == 464 &gt;&gt;&gt; (xyFit[:, 0] - lines.x)[select] array([-0.01342672, 0.00048829, 0.00229483, -0.00329692, 0.01108743, 0.00165179, -0.02782915, 0.00258571, -0.00547261, -0.00282912, -0.00731705, -0.02812789, 0.01557468, 0.01771366, 0.1476121 , 0.03942108]) </pre> </div></div> <p>The above values are with <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-780" title="reduceArcs should include all the fibres in the output DetectorMap" class="issue-link" data-issue-key="PIPE2D-780"><del>PIPE2D-780</del></a>, but I get very similar values with master.</p> <p>Looks like user error, as Paul suspected.  Closing.</p> Development Rank 0|02qpt6:508yl0chzzy000001r Sprint 2DDRP-2021 A3